Closed Bug 2041238 Opened 4 months ago Closed 1 month ago

"Discover extensions" button in the extensions panel is not disabled by policy

Categories

(Firefox :: Enterprise Policies, defect, P3)

Product:
Firefox
Component:
Enterprise Policies
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
156 Branch
Tracking Flags:
Tracking Status
firefox153 --- wontfix
firefox156 --- fixed

People

(Reporter: yuki, Assigned: mkaply)

References

Details

Attachments

(2 files)

Bug 2041238 - Hide unified extensions panel "Discover extensions" button when discopane is disabled. r?#extension-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2041238 - Lock extensions.getAddons.showPane when InstallAddonsPermission blocks installs. r?jmendez
48 bytes, text/x-phabricator-request
Details | Review

Setting the policy ExtensionSettings to disable all extensions hides the "Recommendations" in the addons manager, but does not affect to the panel shown by the "Extensions" toolbar button.

Steps to reproduce

  1. Create distribution/policies.json with the contents: 
    { "policies": {
  "ExtensionSettings": {
    "*": {
      "type": "extension",
      "installation_mode": "blocked"
    }
  }
}}
  2. Start Firefox(Nightly) with new profile.
  3. Click the "Extensions" button in the toolbar.

Actual result

A panel describing extensions opens, and it has an effective button with the label "Discover extensions".

Expected result

A panel opens but there is no effective button about discovering extensions.
Or, the button does not show effective panel.

Environment

  • Nightly 153.0a1 build ID: 20260520211620
  • Windows 11

https://searchfox.org/firefox-main/rev/cebc55aab4d2661d1f6c2d1526362947ec4016c1/browser/components/enterprisepolicies/Policies.sys.mjs#1547
The discover pane looks to be designed to be disabled with a policy like I posted, thus clickable "Discover extensions" button in the extensions panel looks mismatched.

The severity field is not set for this bug.
:mkaply, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(mozilla)
Severity: -- → S4
Flags: needinfo?(mozilla)
Priority: -- → P3
Summary: "Discover extensions" button in the extensions panel is not disabed by policy → "Discover extensions" button in the extensions panel is not disabled by policy
See Also: → 2063090
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Duplicate of this bug: 2061705
Pushed by mozilla@kaply.com: https://github.com/mozilla-firefox/firefox/commit/2d9ed3886eeb https://hg.mozilla.org/integration/autoland/rev/9c4832c131ad Hide unified extensions panel "Discover extensions" button when discopane is disabled. r=extension-reviewers,robwu

https://hg.mozilla.org/mozilla-central/rev/9c4832c131ad

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox156: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch

Did you want to nominate this for the Fx156 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

Fixed the Discover extensions button still appearing in the extensions panel when the ExtensionSettings policy blocks all extension installations.

Flags: needinfo?(mozilla)

Nope, I don't think this belongs in the release notes.

Flags: needinfo?(mozilla)
Pushed by mozilla@kaply.com: https://github.com/mozilla-firefox/firefox/commit/d69461e41ec3 https://hg.mozilla.org/integration/autoland/rev/d7a8a599b087 Lock extensions.getAddons.showPane when InstallAddonsPermission blocks installs. r=jneuberger
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in before you can comment on or make changes to this bug.