Closed Bug 2053447 Opened 2 months ago Closed 1 month ago

Implement launch on login for macOS

Categories

(Firefox :: Shell Integration, task, P3)

All
macOS
task

Tracking

()

RESOLVED FIXED
156 Branch
Tracking Status
relnote-firefox --- 156+
firefox156 --- fixed

People

(Reporter: iholmes, Assigned: iholmes)

References

Details

(Whiteboard: [FIDEDI])

Attachments

(5 files, 1 obsolete file)

Launch on login support is currently only implemented for Windows. it should be possible on macOS

See Also: → 2056455

Implement a macOS interface for adding Login Items (aka LaunchOnLogin) and make a wrapper for LaunchOnLogin that calls the correct OS version.

Port the WindowsDefaultLaunchOnLogin to use the new generic LaunchOnLogin interface

Use the new LaunchOnLogin API to determine if LoL is supported and call the correct OS implementation

f3

Rename all the windowsLaunchOnLogin preferences to launchOnLogin and upgrade profiles as the feature is no longer Windows only.

Attachment #9619746 - Attachment is obsolete: true

Update to support the DisableLaunchOnLogin enterprise policy

Regressions: 2061565
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/17c317251513 https://hg.mozilla.org/integration/autoland/rev/bca44a4f0943 Revert "Bug 2053447: Part 5 - Update for enterprise policies.r=mkaply" for causing bc failures at /browser_suppressTips.js

Backed out for causing bc failures at /browser_suppressTips.js
Backout Link
Push with failures
push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/suppress-tips/browser_suppressTips.js | updateApplied - updateAppliedTime pref should be updated when booting this test - 0 != 0
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/browser_searchTips.js | newtab - Test timed out

Status: RESOLVED → REOPENED
Flags: needinfo?(iholmes)
Resolution: FIXED → ---

Hey! i just did a try run for this stack and this failure did not show up - https://treeherder.mozilla.org/jobs?repo=try&revision=d085bbfe64a661a2b5d2381b97dfab29709e87e4&selectedTaskRun=XZqXbC82TZeUDeLntohcGQ.0
am i missing something? the failure looks unrelated to the patches

Flags: needinfo?(iholmes) → needinfo?(silaghipaul)
Flags: needinfo?(silaghipaul) → needinfo?(asilaghi)
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6cee80f87168 https://hg.mozilla.org/mozilla-central/rev/5d8f92a89915 Revert "Bug 2053447: Part 5 - Update for enterprise policies.r=mkaply" for causing bc failures @ browser_searchTips.js
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 155 Branch → ---

FYI, over in bug 2061896, I made a change to WindowsLaunchOnLogin.sys.mjs in the old location. Looking at the git commit, it seems like your move was registered as a move and you didn't change the part of the file that I touched, so hopefully it won't be a problem, but I figured I'd mention it as something to watch out for.

Flags: needinfo?(iholmes)

Did you want to nominate this for a relnote? Is this enabled by default?
If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

Firefox on macOS can now be set to open automatically when the computer starts up, from the Startup section of Settings.

Flags: needinfo?(iholmes)

The wording sounds good to me, and I think we probably do want it included. It is enabled by default for new installations.

I'll check with david before setting the flag though.

Flags: needinfo?(iholmes) → needinfo?(drubino)

"Enabled" means "the feature is available", right? And sure, we can relnote this. The wording sounds good to me.

Flags: needinfo?(drubino)

Thanks, added to the Fx156 nightly release notes, please allow 30 minutes for the site to update.

See Also: → 2064113
See Also: → 2064574
Regressions: 2065015
Regressions: 2065018
Regressions: 2065022
Regressions: 2065031
No longer regressions: 2065022
No longer regressions: 2065031
No longer regressions: 2065018
See Also: → 2065571
Regressions: 2065022
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in before you can comment on or make changes to this bug.