Closed
Bug 1625924
Opened 6 years ago
Closed 1 month ago
Make browser/components/syncedtabs/sidebar.xhtml an HTML file
Categories
(Firefox :: Sync, task, P3)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
157 Branch
| Tracking | Status | |
|---|---|---|
| firefox157 | --- | fixed |
People
(Reporter: ntim, Assigned: varghese.noah)
Details
Attachments
(1 file)
It's almost fully an HTML file at this point and doesn't use XHTML specific features.
https://searchfox.org/mozilla-central/source/browser/components/syncedtabs/sidebar.xhtml#1
Steps to fix this:
- Remove
xmlns="http://www.w3.org/1999/xhtml" - Remove
<?xml version="1.0" encoding="UTF-8"?> - Make the 2nd
<script>close properly in HTML fashion - Run
hg mv browser/components/syncedtabs/sidebar.xhtml browser/components/syncedtabs/sidebar.html - Update usages at: https://searchfox.org/mozilla-central/search?q=sidebar.xhtml&case=true®exp=false&path=
|
Reporter | |
Updated•6 years ago
|
Component: DOM: Core & HTML → General
Product: Core → Firefox
|
||
Updated•6 years ago
|
Mentor: gijskruitbosch+bugs
Component: General → Sync
Whiteboard: [lang=js][lang=html]
|
|
Reporter | |
Comment 2•6 years ago
|
||
Bug 1626179 just made it a bit more tricky to fix this.
|
|
Reporter | |
Comment 4•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #3)
Do we use XUL persistence anywhere in here?
I don't think we do, the persisted width is on: https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/browser/base/content/browser.xhtml#1364
Flags: needinfo?(ntim.bugs)
|
|
||
Comment 5•6 years ago
|
||
If we're still using XUL here, this doesn't seem easily fixable right now.
Mentor: gijskruitbosch+bugs
Whiteboard: [lang=js][lang=html]
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Severity: normal → S3
|
Assignee | |
Comment 6•1 month ago
|
||
|
||
Updated•1 month ago
|
Assignee: nobody → varghese.noah
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/548abb538fe8
https://hg.mozilla.org/integration/autoland/rev/c10df8abd258
Convert browser/components/syncedtabs/sidebar from xhtml to html. r=firefox-desktop-core-reviewers ,desktop-theme-reviewers,mossop,dao
|
||
Comment 8•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox157:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•