Closed Bug 1928343 Opened 1 year ago Closed 1 month ago

Remove unused js/src/irregexp/imported/property-sequences.{h,cc}

Categories

(Core :: JavaScript Engine, task, P2)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
156 Branch
Tracking Flags:
Tracking Status
firefox156 --- fixed

People

(Reporter: anba, Assigned: ExplodingJoysticks, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1928343 - Delete unused files property-sequences.h and property-sequences.cc in js/src/irregexp/imported r=mgaudet
48 bytes, text/x-phabricator-request
Details | Review

js/src/irregexp/imported/property-sequences.{h,cc} are unused and are no longer present in upstream irregexp.

Severity: -- → N/A
Priority: -- → P2
Mentor: mgaudet

Why doesn't the update bot script mention this issue?

import_irregexp.py doesn't empty the directory before updating. There are a few files in there that aren't updated each time: regexp-macro-assembler-arch.h is written by hand, and special-case.cc is generated at build time upstream, but regenerated manually for us (because it almost never changes).

Assignee: nobody → ExplodingJoysticks
Status: NEW → ASSIGNED
Pushed by mgaudet@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b9b4fcf2bf83 https://hg.mozilla.org/integration/autoland/rev/1d45ca167778 Delete unused files property-sequences.h and property-sequences.cc in js/src/irregexp/imported r=iain

https://hg.mozilla.org/mozilla-central/rev/1d45ca167778

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox156: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in before you can comment on or make changes to this bug.