Remove unused lightweightThemes.getMoreURL pref
Categories
(Firefox :: Toolbars and Customization, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox156 | --- | fixed |
People
(Reporter: gregp, Assigned: gopal, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
It became unused in bug 1917913
Updated•9 months ago
|
Comment 3•2 months ago
|
||
Thanks Gregory for the clean up.
However, my report, as good first bugs with details, were probably more likely to be fixed.
Are you ok if i update these bugs?
Comment 5•2 months ago
|
||
Repurposing this as a good first bug, per comment 3/comment 4 — thanks Gregory.
The preference lightweightThemes.getMoreURL is defined in browser/app/profile/firefox.js but is never read anywhere in mozilla-central. It became unused in bug 1917913. Please remove its definition line.
Link to the code:
https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#239
To verify the fix:
- Confirm the pref has no remaining users by searching for its name on
https://searchfox.org/mozilla-central/search?q=lightweightThemes.getMoreURL
(only the definition should match). - Build the tree to make sure nothing breaks:
./mach build
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Updated•2 months ago
|
| Assignee | ||
Comment 6•1 month ago
|
||
I confirmed the pref isn't used anywhere by doing a code search.
The build passed.
Updated•1 month ago
|
Comment 8•1 month ago
|
||
| bugherder | ||
Updated•1 month ago
|
Description
•