Closed Bug 2003172 Opened 10 months ago Closed 1 month ago

Remove unused lightweightThemes.getMoreURL pref

Categories

(Firefox :: Toolbars and Customization, task, P5)

task

Tracking

()

RESOLVED FIXED
156 Branch
Tracking Status
firefox156 --- fixed

People

(Reporter: gregp, Assigned: gopal, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

It became unused in bug 1917913

Severity: -- → N/A
Priority: -- → P5
Duplicate of this bug: 2053554
Duplicate of this bug: 2053564

Thanks Gregory for the clean up.
However, my report, as good first bugs with details, were probably more likely to be fixed.
Are you ok if i update these bugs?

Flags: needinfo?(gregp)

Yes.

Flags: needinfo?(gregp)

Repurposing this as a good first bug, per comment 3/comment 4 — thanks Gregory.

The preference lightweightThemes.getMoreURL is defined in browser/app/profile/firefox.js but is never read anywhere in mozilla-central. It became unused in bug 1917913. Please remove its definition line.

Link to the code:
https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#239

To verify the fix:

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Mentor: sledru
Keywords: good-first-bug
Whiteboard: [lang=js]

I confirmed the pref isn't used anywhere by doing a code search.
The build passed.

Assignee: nobody → gopal
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in before you can comment on or make changes to this bug.