Differential D279944

Bug 2010968: Dictionary cleanup, and handle errors better r=#necko-reviewers!
ClosedPublic
Actions

Authored by jesup on Jan 21 2026, 9:36 PM.

Tags

Referenced Files

	Unknown Object (File)
	Aug 20 2026, 7:29 PM

	Unknown Object (File)
	Aug 11 2026, 2:40 PM

	Unknown Object (File)
	Aug 8 2026, 12:28 PM

	Unknown Object (File)
	Jul 26 2026, 10:24 PM

	Unknown Object (File)
	Jul 23 2026, 11:32 PM

	Unknown Object (File)
	Jul 21 2026, 10:21 AM

	Unknown Object (File)
	Jul 20 2026, 6:11 AM

	Unknown Object (File)
	Jul 19 2026, 6:11 AM

View All 61 Files

Subscribers

Details

Reviewers

Group Reviewers

necko-reviewers

Commits

rFIREFOXAUTOLANDe6baf9d9a8e8: Bug 2010968: Dictionary cleanup, and handle errors better r=necko-reviewers…

Bugzilla Bug ID

Summary

In particular, if we Suspend for 5+ seconds and timeout

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

jesup created this revision.Jan 21 2026, 9:36 PM

Herald added a project: secure-revision. · View Herald TranscriptJan 21 2026, 9:36 PM

jesup added a child revision: D279945: Bug 2010968: Add OPEN_ALWAYS flag to open even if revalidating for Dictionary loads r=#necko-reviewers!.Jan 21 2026, 9:36 PM

phab-bot published this revision for review.Jan 21 2026, 9:36 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: mayhemer. · View Herald TranscriptJan 21 2026, 9:36 PM

Harbormaster completed remote builds in B900933: Diff 1188917.Jan 21 2026, 9:51 PM

jesup updated this revision to Diff 1188945.Jan 21 2026, 10:17 PM

Harbormaster failed remote builds in B900961: Diff 1188945!Jan 21 2026, 10:54 PM

jesup updated this revision to Diff 1189114.Jan 22 2026, 2:32 AM

Harbormaster completed remote builds in B901099: Diff 1189114.Jan 22 2026, 2:45 AM

jesup updated this revision to Diff 1189121.Jan 22 2026, 2:48 AM

Harbormaster completed remote builds in B901106: Diff 1189121.Jan 22 2026, 3:12 AM

jesup updated this revision to Diff 1189142.Jan 22 2026, 4:29 AM

Harbormaster completed remote builds in B901116: Diff 1189142.Jan 22 2026, 4:51 AM

jesup updated this revision to Diff 1189156.Jan 22 2026, 5:11 AM

Harbormaster completed remote builds in B901145: Diff 1189156.Jan 22 2026, 5:35 AM

valentin mentioned this in D279945: Bug 2010968: Add OPEN_ALWAYS flag to open even if revalidating for Dictionary loads r=#necko-reviewers!.Jan 22 2026, 9:34 AM

valentin accepted this revision.Jan 22 2026, 11:30 AM

valentin added a project: testing-exception-unchanged (Doesn't change behavior for users).

valentin added a subscriber: valentin.

valentin added inline comments.

netwerk/cache2/CacheEntry.cpp
734 ↗	(On Diff #1189156)	I think the cacheEntry changes belong in D279945.
netwerk/cache2/Dictionary.cpp
558–559	Since we're refactoring this, maybe we can do: auto cleanup = MakeScopeExit([&] { CleanupOnCacheData(result); mStopReceived = true; }); if (NS_FAILED(rv)) { return rv; } ... if (mHash.IsEmpty()) return NS_OK; ... and so on

This revision is now accepted and ready to land.Jan 22 2026, 11:30 AM

jesup marked 2 inline comments as done.Jan 22 2026, 4:18 PM

jesup updated this revision to Diff 1189554.Jan 22 2026, 4:58 PM

jesup updated this revision to Diff 1189616.Jan 22 2026, 6:11 PM

Harbormaster failed remote builds in B901470: Diff 1189554!Jan 22 2026, 7:34 PM

The analysis task source-test-mozlint-rejected-words failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-clang-format failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-clang-format failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-header-guards failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-clang-external failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-mingw-cap failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-eslint failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Harbormaster failed remote builds in B901514: Diff 1189616!Jan 22 2026, 7:54 PM

This revision was landed with ongoing or failed builds.Jan 22 2026, 11:07 PM

Closed by commit rFIREFOXAUTOLANDe6baf9d9a8e8: Bug 2010968: Dictionary cleanup, and handle errors better r=necko-reviewers… (authored by jesup, committed by rjesup@mozilla.com <rjesup@mozilla.com>). · Explain Why

This revision was automatically updated to reflect the committed changes.

rjesup@mozilla.com <rjesup@mozilla.com> added a commit: rFIREFOXAUTOLANDe6baf9d9a8e8: Bug 2010968: Dictionary cleanup, and handle errors better r=necko-reviewers….

rjesup@mozilla.com <rjesup@mozilla.com> mentioned this in rFIREFOXBETAe6baf9d9a8e8: Bug 2010968: Dictionary cleanup, and handle errors better r=necko-reviewers….Feb 23 2026, 2:42 PM

rjesup@mozilla.com <rjesup@mozilla.com> mentioned this in rFIREFOXRELEASEe6baf9d9a8e8: Bug 2010968: Dictionary cleanup, and handle errors better r=necko-reviewers….Mar 18 2026, 6:41 PM

Revision Contents
Changeset List

Path

Size

netwerk/

cache2/

CacheFileMetadata.cpp

3 lines

2 lines

119 lines

Diff 1189871

netwerk/cache2/CacheFileMetadata.cpp

Loading...

netwerk/cache2/Dictionary.h

Loading...

netwerk/cache2/Dictionary.cpp

Loading...