aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/flow.c
diff options
authorLuc Van Oostenryck <luc.vanoostenryck@gmail.com>2020-02-18 00:17:17 +0100
committerLuc Van Oostenryck <luc.vanoostenryck@gmail.com>2021-04-17 20:43:01 +0200
commit0dd7ffba2e72bb83012c6d6e8a5a98ed31c4168e (patch)
tree372dc5f797f4ac3146da2f2a52080898b80faa2b /flow.c
parente19144ebc795f522a271763b0384610da792bd1a (diff)
downloadsparse-dev-0dd7ffba2e72bb83012c6d6e8a5a98ed31c4168e.tar.gz
memops: dominates()'s first arg is redundant
The first argument of dominates(), 'pseudo', is simply the 'src' pseudo of it's second argument, the load or store instruction. It's thus not needed to give it in a separate argument. So, remove this redundant argument, since it makes things slightly clearer. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Diffstat (limited to 'flow.c')
-rw-r--r--flow.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/flow.c b/flow.c
index c5319ae3..2e35bc1b 100644
--- a/flow.c
+++ b/flow.c
@@ -469,7 +469,7 @@ static inline int distinct_symbols(pseudo_t a, pseudo_t b)
*
* Return 0 if it doesn't, and -1 if you don't know.
*/
-int dominates(pseudo_t pseudo, struct instruction *insn, struct instruction *dom, int local)
+int dominates(struct instruction *insn, struct instruction *dom, int local)
{
switch (dom->opcode) {
case OP_CALL: case OP_ENTRY:
@@ -486,7 +486,7 @@ int dominates(pseudo_t pseudo, struct instruction *insn, struct instruction *dom
return 0;
}
- if (dom->src != pseudo) {
+ if (dom->src != insn->src) {
if (local)
return 0;
/* We don't think two explicitly different symbols ever alias */