feat: Limit permanent warning dismissal to affirmative actions (#292)

* feat: Limit permanent warning dismissal to affirmative actions

Permanently dismissing a warning while selecting the "cancel" option is
confusing as generally cancelling a dialog does not persist selections.

* feat: Rephrase download optimized version cancel option

This option is not so much a cancellation, but either a deferment of a
highly-recommended action or an acceptance of actively choosing to not
heed direct advice for solving an system issue. Rephrasing the option to
align with this better communicates the choice and makes the permanent
dismissal option more understandable.

Author: dcalhoun

src/components/ai-clear-history-reminder.tsx

@@ -68,11 +68,11 @@ function AIClearHistoryReminder( {
 			cancelId: CANCEL_BUTTON_INDEX,
 		} );
 
-		if ( checkboxChecked ) {
-			localStorage.setItem( 'dontShowClearMessagesWarning', 'true' );
-		}
-
 		if ( response === CLEAR_CONVERSATION_BUTTON_INDEX ) {
+			if ( checkboxChecked ) {
+				localStorage.setItem( 'dontShowClearMessagesWarning', 'true' );
+			}
+
 			clearInput();
 		}
 	}, [ clearInput ] );

src/components/ai-input.tsx

@@ -97,11 +97,11 @@ export const AIInput = ( {
 			cancelId: CANCEL_BUTTON_INDEX,
 		} );
 
-		if ( checkboxChecked ) {
-			localStorage.setItem( 'dontShowClearMessagesWarning', 'true' );
-		}
-
 		if ( response === CLEAR_CONVERSATION_BUTTON_INDEX ) {
+			if ( checkboxChecked ) {
+				localStorage.setItem( 'dontShowClearMessagesWarning', 'true' );
+			}
+
 			clearInput();
 		}
 	};

src/components/content-tab-snapshots.tsx

@@ -101,11 +101,11 @@ function SnapshotRow( {
 				checkboxChecked: false,
 			} );
 
-			if ( checkboxChecked ) {
-				localStorage.setItem( 'dontShowUpdateWarning', 'true' );
-			}
-
 			if ( response === UPDATE_BUTTON_INDEX ) {
+				if ( checkboxChecked ) {
+					localStorage.setItem( 'dontShowUpdateWarning', 'true' );
+				}
+
 				updateDemoSite( snapshot, selectedSite );
 			}
 		} else {

src/renderer.ts

@@ -97,7 +97,7 @@ getIpcApi()
 									'Downloading the optimized version of Studio will provide better performance.'
 							  ),
 					checkboxLabel: __( "Don't show this warning again" ),
-					buttons: [ __( 'Download' ), __( 'Cancel' ) ],
+					buttons: [ __( 'Download' ), __( 'Not now' ) ],
 					cancelId: 1,
 				} );