Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

make ZZ work in vim mode#1041

Merged
kazup01 merged 1 commit into
BoostIO:masterfrom
machellerogden:master
Nov 15, 2017
Merged

make ZZ work in vim mode#1041
kazup01 merged 1 commit into
BoostIO:masterfrom
machellerogden:master

Conversation

@machellerogden

Copy link
Copy Markdown
Contributor

As an avid vim user, I often use "ZZ" while in normal mode to quickly save and exit. This PR makes that bit of vim functionality work in Boostnote as well.

@kazup01

kazup01 commented Oct 31, 2017

Copy link
Copy Markdown
Member

Thanks for your contribution @machellerogden ! This feature is looks good.
Could you fix CI error?

@machellerogden

Copy link
Copy Markdown
Contributor Author

I'll check it out and update. Won't have time to loop back around to this until next week though. Thanks for your consideration!

@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Nov 7, 2017
@kazup01 kazup01 self-requested a review November 15, 2017 04:46

@kazup01 kazup01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 8884db8 into BoostIO:master Nov 15, 2017
@kazup01

kazup01 commented Nov 15, 2017

Copy link
Copy Markdown
Member

Merged. I will fix CI error soon. Thank you for your contribution @machellerogden :)

@kazup01 kazup01 added next release (v0.8.17) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. Next Release labels Nov 15, 2017
@kazup01 kazup01 mentioned this pull request Nov 15, 2017
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants