Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

only make the selected tag active#1049

Merged
kazup01 merged 1 commit into
BoostIO:masterfrom
mslourens:selected-tag-issue
Nov 5, 2017
Merged

only make the selected tag active#1049
kazup01 merged 1 commit into
BoostIO:masterfrom
mslourens:selected-tag-issue

Conversation

@mslourens

Copy link
Copy Markdown
Contributor

Fixes #981

The tag got highlighted when the current pathname contained the tagname (so for pathname /tag/boostnote both boost and boostnote got highlighted). I changed this by checking the exact name of the tag in the pathname.

@kazup01

kazup01 commented Nov 2, 2017

Copy link
Copy Markdown
Member

Thank you for your contribution! We will check it sometime soon.

@kazup01 kazup01 requested a review from sosukesuzuki November 2, 2017 02:37

@sosukesuzuki sosukesuzuki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mslourens !
Thank you for your good contributing!
LGTM!!!!!

@kazup01 kazup01 merged commit 3df8cbb into BoostIO:master Nov 5, 2017
@kazup01

kazup01 commented Nov 5, 2017

Copy link
Copy Markdown
Member

Merged. Thank you for your contribution! @mslourens

@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
@mslourens mslourens deleted the selected-tag-issue branch January 17, 2018 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants