Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

React.PropTypes is deprecated from React 15.5#1113

Merged
kohei-takata merged 1 commit into
BoostIO:masterfrom
yosmoc:react_proptypes_deprecated
Nov 26, 2017
Merged

React.PropTypes is deprecated from React 15.5#1113
kohei-takata merged 1 commit into
BoostIO:masterfrom
yosmoc:react_proptypes_deprecated

Conversation

@yosmoc

@yosmoc yosmoc commented Nov 12, 2017

Copy link
Copy Markdown
Member

Migrated by react-codemod + fixed trivial things by hand.

yarn lint

Before

...
/Users/yoshi/src/github.com/yosmoc/Boostnote/browser/main/TopBar/index.js
    1:1   warning  React.PropTypes is deprecated since React 15.5.0, use the npm module prop-types instead  react/no-deprecated
    5:8   warning  'NewNoteModal' is defined but never used                                                 no-unused-vars
   10:9   warning  'dialog' is assigned a value but never used                                              no-unused-vars
   12:7   warning  'OSX' is assigned a value but never used                                                 no-unused-vars
  124:11  warning  'config' is never reassigned. Use 'const' instead                                        prefer-const
  124:19  warning  'style' is never reassigned. Use 'const' instead                                         prefer-const
  124:26  warning  'data' is assigned a value but never used                                                no-unused-vars
  124:26  warning  'data' is never reassigned. Use 'const' instead                                          prefer-const
  124:32  warning  'location' is never reassigned. Use 'const' instead                                      prefer-const
...
✖ 568 problems (0 errors, 568 warnings)

After

...
/Users/yoshi/src/github.com/yosmoc/Boostnote/browser/main/TopBar/index.js
    6:8   warning  'NewNoteModal' is defined but never used             no-unused-vars
   11:9   warning  'dialog' is assigned a value but never used          no-unused-vars
   13:7   warning  'OSX' is assigned a value but never used             no-unused-vars
  125:11  warning  'config' is never reassigned. Use 'const' instead    prefer-const
  125:19  warning  'style' is never reassigned. Use 'const' instead     prefer-const
  125:26  warning  'data' is assigned a value but never used            no-unused-vars
  125:26  warning  'data' is never reassigned. Use 'const' instead      prefer-const
  125:32  warning  'location' is never reassigned. Use 'const' instead  prefer-const
...
✖ 527 problems (0 errors, 527 warnings)
@BoostnoteBot

BoostnoteBot commented Nov 12, 2017

Copy link
Copy Markdown
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.
@kazup01 kazup01 requested a review from kohei-takata November 12, 2017 02:53
@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 12, 2017
@kazup01

kazup01 commented Nov 15, 2017

Copy link
Copy Markdown
Member

Hi @yosmoc , thanks for your support every time.
Sorry, there is a conflict. Could you fix it?
@yosmoc yosmoc force-pushed the react_proptypes_deprecated branch from 2b6c318 to e96dcd6 Compare November 15, 2017 07:56
@yosmoc

yosmoc commented Nov 15, 2017

Copy link
Copy Markdown
Member Author

@kazup01 Resolved conflict!
@kazup01

kazup01 commented Nov 15, 2017

Copy link
Copy Markdown
Member

Thanks!
@yosmoc yosmoc force-pushed the react_proptypes_deprecated branch from e96dcd6 to f2435fd Compare November 15, 2017 12:03
@yosmoc

yosmoc commented Nov 15, 2017

Copy link
Copy Markdown
Member Author

Sorry, I found my mistake. I pushed again now.
@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Nov 18, 2017
@kazup01 kazup01 mentioned this pull request Nov 24, 2017
Merged
kohei-takata
kohei-takata reviewed Nov 25, 2017
View reviewed changes
Comment thread browser/components/RealtimeNotification.js Outdated
@@ -1,4 +1,5 @@
import React, { PropTypes } from 'react'
import PropTypes from 'prop-types'

@kohei-takata kohei-takata Nov 25, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yosmoc
Please resolve conflict.
This line is not needed, I think.

@yosmoc yosmoc Nov 25, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!
@yosmoc
React.PropTypes is deprecated from React 15.5
edaa071 
Migrated by react-codemod + minor fix by hand.
@yosmoc yosmoc force-pushed the react_proptypes_deprecated branch from f2435fd to edaa071 Compare November 25, 2017 21:34
kohei-takata
kohei-takata approved these changes Nov 26, 2017
View reviewed changes

@kohei-takata kohei-takata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kohei-takata kohei-takata merged commit 6bab108 into BoostIO:master Nov 26, 2017
@kazup01 kazup01 removed the awaiting review ❇️ Pull request is awaiting a review. label Nov 26, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 3, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@yosmoc @BoostnoteBot @kazup01 @kohei-takata