Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

fixed eslint warnings#1170

Merged
kohei-takata merged 1 commit into
BoostIO:masterfrom
mslourens:reduce-lint-errors
Nov 25, 2017
Merged

fixed eslint warnings#1170
kohei-takata merged 1 commit into
BoostIO:masterfrom
mslourens:reduce-lint-errors

Conversation

@mslourens

Copy link
Copy Markdown
Contributor

fixes #1169

Reduces 550+ warnings to 47, which is this one in 47 different files:
React.PropTypes is deprecated since React 15.5.0, use the npm module prop-types instead
I couldn't fix that warning, because we are not using React 15.5.0 but 15.0.2, so this warning doesn't apply for this project.

@BoostnoteBot

Copy link
Copy Markdown
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01 kazup01 self-requested a review November 24, 2017 16:07
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Nov 24, 2017
@kazup01

kazup01 commented Nov 24, 2017

Copy link
Copy Markdown
Member

Thank you for your contribution. You are amazing!
We will check it tomorrow.

React.PropTypes is deprecated is fixed at #1113 and wait for review :)

@kazup01 kazup01 requested review from kohei-takata and removed request for kazup01 November 24, 2017 16:14

@kohei-takata kohei-takata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kohei-takata kohei-takata merged commit 6b6a415 into BoostIO:master Nov 25, 2017
@kazup01 kazup01 added next release and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 26, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 3, 2017
@mslourens mslourens deleted the reduce-lint-errors branch January 17, 2018 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants