Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Added border radius & background color to NavToggleButton #1236

Merged
kazup01 merged 1 commit into
BoostIO:masterfrom
Alaev:patch-1
Dec 4, 2017
Merged

Added border radius & background color to NavToggleButton #1236
kazup01 merged 1 commit into
BoostIO:masterfrom
Alaev:patch-1

Conversation

@Alaev

@Alaev Alaev commented Dec 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

At the moment when you hover the left menu icon its hard to see that you fully hovering it, yes there is a white color and a cursor icon I was thinking it would be useful to have a more visual effect

Folded out:
screen shot 2017-12-04 at 15 04 56

Folded in:
screen shot 2017-12-04 at 15 04 42

White theme:
screen shot 2017-12-04 at 15 02 42
@Alaev
Added border radius with background color
a058a77 
At the moment when you hover the left menu icon its hard to see that you fully hovering it, yes there is a white color and a cursor icon I was thinking it would be useful to have a more visual effect
@BoostnoteBot

BoostnoteBot commented Dec 4, 2017

Copy link
Copy Markdown
Collaborator

Please make sure to be pasted screenshots of all your changes.
@Alaev Alaev changed the title Added border radius with background color Dec 4, 2017
@Alaev Alaev changed the title Added border radius with background color to NavToggleButton Dec 4, 2017
@kazup01 kazup01 self-requested a review December 4, 2017 13:28
kazup01
kazup01 approved these changes Dec 4, 2017
View reviewed changes

@kazup01 kazup01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kazup01 kazup01 merged commit 31351e3 into BoostIO:master Dec 4, 2017
@kazup01

kazup01 commented Dec 4, 2017

Copy link
Copy Markdown
Member

Looks great! Thanks for your contribution ;)
Are you UI designer? Particularly we are waiting for the UI improvement ideas.
@Alaev

Alaev commented Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

@kazup01 Hey, I am a frontend dev, but I do love a good UI :))
I will try to add more stuff in my spare time.
Great app keep the good work!
@Alaev Alaev deleted the patch-1 branch December 4, 2017 14:49
@Alaev Alaev restored the patch-1 branch December 4, 2017 14:50
@kazup01

kazup01 commented Dec 4, 2017

Copy link
Copy Markdown
Member

@Alaev Wow I'm glad to hear that ;) Cheers 🍻
@Alaev Alaev deleted the patch-1 branch December 4, 2017 15:02
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@Alaev @BoostnoteBot @kazup01