Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Ability to stop auto update#2617

Merged
Rokt33r merged 1 commit into
BoostIO:masterfrom
hsiehjack:issue-2140
Nov 21, 2019
Merged

Ability to stop auto update#2617
Rokt33r merged 1 commit into
BoostIO:masterfrom
hsiehjack:issue-2140

Conversation

@hsiehjack

@hsiehjack hsiehjack commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

Fix #2140

image

@daiyam

daiyam commented Nov 18, 2018

Copy link
Copy Markdown
Contributor

@hsiehjack please use the existing config (browser/main/lib/ConfigManager.js)

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 18, 2018
@daiyam

daiyam commented Dec 16, 2018

Copy link
Copy Markdown
Contributor

@hsiehjack Are you planning the make the change? It would be good to have your PR.

@hsiehjack

Copy link
Copy Markdown
Contributor Author

@daiyam I made the changes already. Looks like there was a build fail. I will have to take a look at what happen.

@RonWalker22

Copy link
Copy Markdown
Contributor

Any updates on this?

@hsiehjack hsiehjack force-pushed the issue-2140 branch 2 times, most recently from 6f3417f to bdd03c4 Compare August 6, 2019 07:59
@hsiehjack

Copy link
Copy Markdown
Contributor Author

Sorry for the long wait. This is ready for review.

@Flexo013

Flexo013 commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

@hsiehjack It looks like there are more conflicts. Could you resolve these, then we'll get this approved asap?

@hsiehjack

Copy link
Copy Markdown
Contributor Author

@Flexo013 conflict fixed.

@Rokt33r

Rokt33r commented Nov 6, 2019

Copy link
Copy Markdown
Member

I'll review this tomorrow!

@Rokt33r

Rokt33r commented Nov 18, 2019

Copy link
Copy Markdown
Member

Sorry I've been insanely busy recently... I'll try to test it tonight or tomorrow. No more delaying I promise..! 🙏

@Rokt33r

Rokt33r commented Nov 21, 2019

Copy link
Copy Markdown
Member

Confirmed that it's working well on macOS. I'm testing on WIndows now.

@Rokt33r Rokt33r removed the awaiting review ❇️ Pull request is awaiting a review. label Nov 21, 2019
@Rokt33r Rokt33r added this to the v0.14.0 milestone Nov 21, 2019
@Rokt33r Rokt33r merged commit d78f6b7 into BoostIO:master Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

6 participants