This repository was archived by the owner on May 12, 2026. It is now read-only.
Removed erroneous parameter resulting in PlantUML server URL not being used#2945
Merged
Conversation
Contributor
Author
|
@Rokt33r: this seems to be a trivial change, especially if you realize that code similar to this on line 197 is already working. |
Member
|
@docbobo Sorry for my late response... 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When calling into
markdown-it-plantumlan additional parameter was being passed that results in custom PlantUML server configs not being picked up. A few lines lower is similar code for dittaa (via PlantUML server) that is missing this parameter and that works correctlyIssue fixed
#2733
Type of changes
Checklist: