Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Add prefer-const rule and fix code#317

Merged
sota1235 merged 9 commits into
masterfrom
feature-add-esilnt-rule
Mar 21, 2017
Merged

Add prefer-const rule and fix code#317
sota1235 merged 9 commits into
masterfrom
feature-add-esilnt-rule

Conversation

@sota1235

Copy link
Copy Markdown
Contributor

No description provided.

@sota1235 sota1235 self-assigned this Mar 10, 2017
@asmsuechan

asmsuechan commented Mar 10, 2017

Copy link
Copy Markdown
Contributor

Hi @sota1235, it does not work at least in my environment. the way how to test is below:

  1. Add line let a = 1
  2. Run npm run lint

However, nothing happens.

@sota1235

Copy link
Copy Markdown
Contributor Author

@asmsuechan I fixed npm script bug. Then more then 500 errors occurs 😭
So firstly, add prefer-const rule as warning and fix little by little.
Plz review again 🙇

@kohei-takata kohei-takata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@asmsuechan asmsuechan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sota1235

Copy link
Copy Markdown
Contributor Author

Thanks a lot for reviewing.

@sota1235 sota1235 merged commit 359f673 into master Mar 21, 2017
@sota1235 sota1235 deleted the feature-add-esilnt-rule branch March 21, 2017 06:16
@sota1235 sota1235 mentioned this pull request Apr 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants