Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Fix routing for tag filtering (issue #3157)#3191

Merged
Rokt33r merged 1 commit into
BoostIO:masterfrom
AWolf81:fix-tag-routing
Aug 24, 2019
Merged

Fix routing for tag filtering (issue #3157)#3191
Rokt33r merged 1 commit into
BoostIO:masterfrom
AWolf81:fix-tag-routing

Conversation

@AWolf81

@AWolf81 AWolf81 commented Jul 31, 2019

Copy link
Copy Markdown
Contributor

Description

Changed routing to use connected-react-router by dispatching push to Redux store.

Issue fixed

#3157

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 1, 2019

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ���

@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 14, 2019
@Flexo013 Flexo013 requested a review from Rokt33r August 14, 2019 14:04
@Rokt33r Rokt33r removed the needs extra review 🔎 Pull request requires review from an additional reviewer. label Aug 24, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 24, 2019
@Rokt33r Rokt33r merged commit 7d04046 into BoostIO:master Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants