Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

fix: HotkeyTab accidentally set incomplete hotkey, related #3190#3194

Merged
Rokt33r merged 1 commit into
BoostIO:masterfrom
hikerpig:bugfix/hotkeyBug
Sep 2, 2019
Merged

fix: HotkeyTab accidentally set incomplete hotkey, related #3190#3194
Rokt33r merged 1 commit into
BoostIO:masterfrom
hikerpig:bugfix/hotkeyBug

Conversation

@hikerpig

@hikerpig hikerpig commented Aug 1, 2019 •
edited by issuehunt-oss Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Bug reason

Error is thrown in CodeEditor.js due to undefined hotkey input.

function translateHotkey (hotkey) {
  return hotkey.replace(/\s*\+\s*/g, '-').replace(/Command/g, 'Cmd').replace(/Control/g, 'Ctrl')
}

Solution

HotkeyTab should always emit complete hotkeymap.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
IssueHunt Summary

Referenced issues

This pull request has been submitted to:

IssueHunt has been backed by the following sponsors. Become a sponsor
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Aug 25, 2019
ZeroX-DG
ZeroX-DG approved these changes Aug 31, 2019
View reviewed changes

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 31, 2019
@Rokt33r Rokt33r merged commit e9975d1 into BoostIO:master Sep 2, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Sep 2, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Sep 2, 2019
@Rokt33r Rokt33r mentioned this pull request Sep 5, 2019
Closed
@hikerpig hikerpig deleted the bugfix/hotkeyBug branch September 5, 2019 05:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@hikerpig @ZeroX-DG @Rokt33r