Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Fix #3174: Enable dragging of notes#3195

Merged
Rokt33r merged 1 commit into
BoostIO:masterfrom
AWolf81:fix-note-dragging
Aug 24, 2019
Merged

Fix #3174: Enable dragging of notes#3195
Rokt33r merged 1 commit into
BoostIO:masterfrom
AWolf81:fix-note-dragging

Conversation

@AWolf81

@AWolf81 AWolf81 commented Aug 1, 2019

Copy link
Copy Markdown
Contributor

Description

user-drag: none style from MarkdownNoteDetail.styl was applied to every div in the app and disabled dragging of notes.

Changed styling to address only the buttons/icons to disable the dragging of them.

One point where I'm not sure - was dragging of notes to trash icon supported by a previous app version because that's not working but I'm not sure if that was available before.

Issue fixed

#3174

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

Screenshots

Note dragging
Screenrecording_Note_Dragging

Disabled dragging in NoteDetailInfo bar still working
Screenrecording_NoteDetailInfo_not_draggable

A bit difficult to show in a screenrecording but I clicked every icon in the upper right bar and tried to drag the icon. The circle on the cursor during dragging is from the screenrecorder indicating a mousedown.

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 2, 2019

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 I didn't think of the drag n drop note feature is using the default dragging behavior. Thanks for fixing this 👍

@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 2, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r August 2, 2019 23:42
@Rokt33r Rokt33r removed the needs extra review 🔎 Pull request requires review from an additional reviewer. label Aug 24, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 24, 2019
@Rokt33r Rokt33r merged commit 2f1dadf into BoostIO:master Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants