Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Add option to disable the automiatic deletion of un-referenced attach…#3225

Merged
Rokt33r merged 8 commits into
BoostIO:masterfrom
ehhc:option_for_attachment_delete
Aug 30, 2019
Merged

Add option to disable the automiatic deletion of un-referenced attach…#3225
Rokt33r merged 8 commits into
BoostIO:masterfrom
ehhc:option_for_attachment_delete

Conversation

@ehhc

@ehhc ehhc commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

…ments -> might fix #3203

@Rokt33r what do you think about this?
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 26, 2019
@ZeroX-DG

ZeroX-DG commented Aug 26, 2019

Copy link
Copy Markdown
Member

@ehhc , in this case, do the user have anyway to know how many unused attachments that he/she has? And is there a way for the users to easily remove all of them to save space?
@ehhc

ehhc commented Aug 27, 2019

Copy link
Copy Markdown
Contributor Author

hi @ZeroX-DG,
no there is no way to know how many unused attachments exist. furthermore there is no (easy) way to delete them.
I don't have the time (and don't want to) implement that..
If they don't want attachments to be deleted, they have to do it manually in my opinion..
@ZeroX-DG

ZeroX-DG commented Aug 27, 2019

Copy link
Copy Markdown
Member

I'll try to find a way to get unused attachments and make a button to clean those things up and submit a PR to your PR.
@ehhc

ehhc commented Aug 28, 2019

Copy link
Copy Markdown
Contributor Author

@ZeroX-DG @Rokt33r i've merged the changes into my PR
@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 28, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r August 28, 2019 22:17
@ZeroX-DG

ZeroX-DG commented Aug 28, 2019

Copy link
Copy Markdown
Member

@Rokt33r I mark this as need more review because I contributed to this PR too so I can't approve my own code 😄
@Rokt33r Rokt33r removed the needs extra review 🔎 Pull request requires review from an additional reviewer. label Aug 29, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 29, 2019
@Rokt33r

Rokt33r commented Aug 29, 2019

Copy link
Copy Markdown
Member

@ehhc @ZeroX-DG This pr hasn't passed in CI yet...!
@ZeroX-DG

ZeroX-DG commented Aug 29, 2019

Copy link
Copy Markdown
Member

@Rokt33r I missed a small detail and have submitted a PR to fix this. We have to wait for @ehhc to merge it. Sorry for the inconvenience
ehhc#2
@ehhc

ehhc commented Aug 29, 2019

Copy link
Copy Markdown
Contributor Author

@ZeroX-DG @Rokt33r done
@Rokt33r Rokt33r merged commit 28b8141 into BoostIO:master Aug 30, 2019
@ehhc ehhc deleted the option_for_attachment_delete branch August 30, 2019 06:51
@Flexo013 Flexo013 mentioned this pull request Aug 30, 2019
Closed
@Flexo013 Flexo013 mentioned this pull request Nov 27, 2019
Closed
@mfouet mfouet mentioned this pull request Feb 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@ehhc @ZeroX-DG @Rokt33r @Flexo013