Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Used the same hot-key pattern as the one already in use#3256

Closed
Olcod wants to merge 1 commit into
BoostIO:masterfrom
Olcod:issues-3246/use-same-hot-key-pattern-as-everythig-else
Closed

Used the same hot-key pattern as the one already in use#3256
Olcod wants to merge 1 commit into
BoostIO:masterfrom
Olcod:issues-3246/use-same-hot-key-pattern-as-everythig-else

Conversation

@Olcod

@Olcod Olcod commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

Description

Used the same hot-key pattern as everything else

Issue fixed

#3246

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 1, 2019
@Rokt33r

Rokt33r commented Oct 10, 2019

Copy link
Copy Markdown
Member

This conflicts #3257. How should we handle this pr?

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Oct 10, 2019
@Rokt33r

Rokt33r commented Oct 10, 2019

Copy link
Copy Markdown
Member

I misunderstood. No problem. But I committed it directly in here! Thanks for the contribution!
8736666

@Rokt33r Rokt33r closed this Oct 10, 2019
@Rokt33r Rokt33r removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Oct 10, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants