Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Added Czech translation#3264

Merged
Rokt33r merged 7 commits into
BoostIO:masterfrom
PetrTodorov:master
Nov 4, 2019
Merged

Added Czech translation#3264
Rokt33r merged 7 commits into
BoostIO:masterfrom
PetrTodorov:master

Conversation

@PetrTodorov

@PetrTodorov PetrTodorov commented Oct 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Added Czech translation.
Also added Czech language string into other locale files and into the languages.js.

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 7, 2019
@ZeroX-DG

ZeroX-DG commented Oct 9, 2019

Copy link
Copy Markdown
Member

@PetrTodorov Thank you for interested in contributing this to us. Do you have anyone who can review your pull request?
exiltruman
exiltruman reviewed Oct 10, 2019
View reviewed changes
Comment thread locales/cs.json Outdated
"Delete": "Odstranit",
"Interface": "Rozhraní",
"Interface Theme": "Téma vzhledu rozhraní",
"Default": "Defaultní",

@exiltruman exiltruman Oct 10, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a better translation for Default would be Výchozí to make it more accessible without unnecessary tech lingo.

@exiltruman exiltruman Oct 10, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same for default

@PetrTodorov PetrTodorov Oct 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the review. I have just commited the suggested changes.
exiltruman
exiltruman reviewed Oct 11, 2019
View reviewed changes
Comment thread locales/cs.json Outdated
"French": "Francouzština",
"Show \"Saved to Clipboard\" notification when copying": "Zobrazit při kopírování upozornění \"Uloženo do schránky\"",
"All Notes": "Všechny poznámky",
"Starred": "Starred",

@exiltruman exiltruman Oct 11, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Starred similar to Favourites in meaning? If so, the translation could be Oblíbené (direct translation of Favourites).
exiltruman
exiltruman reviewed Oct 11, 2019
View reviewed changes
Comment thread locales/cs.json Outdated
"USER": "UŽIVATEL",
"Token": "Token",
"Storage": "Uložiště",
"Hotkeys": "Horké klávesy",

@exiltruman exiltruman Oct 11, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Horké klávesy a thing in czech? 😄 I'm more used to Klávesové zkratky ('Shortcuts' translated to czech)
@exiltruman

exiltruman commented Oct 11, 2019

Copy link
Copy Markdown

Hi @ZeroX-DG.
I have checked the translations and added my comments.
After these are resolved, I can confirm the translations.
Nice job @PetrTodorov.
@PetrTodorov

PetrTodorov commented Oct 11, 2019

Copy link
Copy Markdown
Contributor Author

Thx for the review once again. Changes comited as suggested.
@ZeroX-DG

ZeroX-DG commented Oct 11, 2019

Copy link
Copy Markdown
Member

Good work @PetrTodorov @exiltruman, Are you guys happy with the PR now? If yes I'll approve this PR:)
@PetrTodorov

PetrTodorov commented Oct 12, 2019

Copy link
Copy Markdown
Contributor Author

As far as I´m concerned, it´s good to go. Thank you for guiding me through the process, I really appreciate it :-)
ZeroX-DG
ZeroX-DG approved these changes Oct 12, 2019
View reviewed changes

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for your contribution guys:)
@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 12, 2019
@Rokt33r

Rokt33r commented Oct 29, 2019

Copy link
Copy Markdown
Member

@PetrTodorov Could you fix the conflicts? I'll merge this pr as soon as you fix.
Simon-the-Sorcerer
Simon-the-Sorcerer suggested changes Oct 29, 2019
View reviewed changes

@Simon-the-Sorcerer Simon-the-Sorcerer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the german translation of 'czech' and added the correct translation.
Comment thread locales/de.json Outdated
@PetrTodorov @Simon-the-Sorcerer
Update locales/de.json
51e36e6 
Fixed german translation as suggested.

Co-Authored-By: Simon <simon81186@aol.com>
@Rokt33r Rokt33r added this to the v0.14.0 milestone Nov 4, 2019
@Rokt33r Rokt33r merged commit abef6c5 into BoostIO:master Nov 4, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Nov 4, 2019
nammn pushed a commit to nammn/Boostnote that referenced this pull request Nov 12, 2019
@PetrTodorov @Simon-the-Sorcerer
Added Czech translation (BoostIO#3264)
6119eec 
* Added Czech translation

* Update locales/de.json

Fixed german translation as suggested.

Co-Authored-By: Simon <simon81186@aol.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

6 participants

@PetrTodorov @ZeroX-DG @exiltruman @Rokt33r @Simon-the-Sorcerer @Flexo013