Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Fix note title#398

Merged
kazup01 merged 11 commits into
BoostIO:masterfrom
asmsuechan:iss-397
Nov 9, 2017
Merged

Fix note title#398
kazup01 merged 11 commits into
BoostIO:masterfrom
asmsuechan:iss-397

Conversation

@asmsuechan

@asmsuechan asmsuechan commented Apr 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

I change to show underscores(_) in title

1825ed2fb5d8232730022ffca935d58b
@asmsuechan asmsuechan mentioned this pull request Apr 8, 2017
Closed
@sota1235

sota1235 commented Apr 22, 2017

Copy link
Copy Markdown
Contributor

I think it is too hard to read. So I added unit test.
https://github.com/asmsuechan/Boostnote/pull/4

Please confirm it.
@sota1235 sota1235 self-requested a review April 22, 2017 03:46
sota1235
sota1235 suggested changes Apr 22, 2017
View reviewed changes

@sota1235 sota1235 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the comment.
@asmsuechan

asmsuechan commented Apr 23, 2017

Copy link
Copy Markdown
Contributor Author

I think so. I assume that PR is better.
@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label May 17, 2017
@asmsuechan asmsuechan mentioned this pull request Jun 9, 2017
Closed
@asmsuechan asmsuechan removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Jun 18, 2017
@sota1235

sota1235 commented Nov 5, 2017

Copy link
Copy Markdown
Contributor

@asmsuechan plz resolve conflicts
@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Nov 7, 2017
@asmsuechan

asmsuechan commented Nov 7, 2017

Copy link
Copy Markdown
Contributor Author

Done.
@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Nov 8, 2017
sota1235
sota1235 approved these changes Nov 9, 2017
View reviewed changes

@sota1235 sota1235 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing
@sota1235 sota1235 added Next Release and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 9, 2017
@kazup01 kazup01 merged commit 11c46ed into BoostIO:master Nov 9, 2017
@kazup01

kazup01 commented Nov 9, 2017

Copy link
Copy Markdown
Member

Merged. Thank you for your contribution @asmsuechan !
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Merged
@kohei-takata kohei-takata mentioned this pull request Dec 3, 2017
Merged
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@asmsuechan @sota1235 @kazup01 @BoostnoteBot