Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Fix new line problem in list and task list#425

Merged
sota1235 merged 1 commit into
BoostIO:masterfrom
aweekj:feature_markdown_note
Apr 22, 2017
Merged

Fix new line problem in list and task list#425
sota1235 merged 1 commit into
BoostIO:masterfrom
aweekj:feature_markdown_note

Conversation

@aweekj

@aweekj aweekj commented Apr 14, 2017

Copy link
Copy Markdown
Contributor

Hello. I changed the code to use newlineAndIndentContinueMarkdownList which is defined in node_module/codemirror/addon/edit/continuelist.jsof library namedcodemirror. It'll fix the new line issues in list and task list.

This will cover these issues in List of the requested features

  • Remove last list item when Enter pressed on empty list item. #42
  • Task list should append - [ ] instead of - when Enter pressed.

Before

before

After

after

@kazup01

kazup01 commented Apr 14, 2017

Copy link
Copy Markdown
Member

Wow, great!! Thank you for your cooperation @aweekj san 🎉 We'll check it!

@ilyeshammadi

Copy link
Copy Markdown

Great work 👍 🥇

@sota1235 sota1235 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us.
Thanks a log :)

@sota1235 sota1235 merged commit eea8f7c into BoostIO:master Apr 22, 2017
@sota1235 sota1235 mentioned this pull request Apr 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants