Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Add file drop on NoteList#793

Merged
kazup01 merged 4 commits into
BoostIO:masterfrom
asmsuechan:add-drop-on-notelist
Sep 23, 2017
Merged

Add file drop on NoteList#793
kazup01 merged 4 commits into
BoostIO:masterfrom
asmsuechan:add-drop-on-notelist

Conversation

@asmsuechan

@asmsuechan asmsuechan commented Aug 12, 2017

Copy link
Copy Markdown
Contributor

context

Drag&drop on NoteList.

before

Nothing.

after

439d0e3727951b609025ae4bf92de217

For test

  • Drag&drop 1 .md file
  • Drag&drop 2 .md files
  • Drag&drop 1 .md and 1 .txt file
  • Drag&drop 1 .html file
  • Drag&drop .pdf file (not work)
  • Drag&drop on trash
  • Not working if the storage is empty
@yashha

yashha commented Aug 12, 2017

Copy link
Copy Markdown

Maybe also txt files?
We could also think about html files, but thats uncommon :) https://domchristie.github.io/to-markdown/

@asmsuechan

asmsuechan commented Aug 12, 2017

Copy link
Copy Markdown
Contributor Author

Hi, @yashha. Thank you for your proposal. Yes, it can. Actually .html file also work. But it is not converted to markdown style for now. And I have to implement a validator or something because there are no restrictions on the type of file extension.
c0177f090eb70c0a1128102e015e114e

@TechIsCool

Copy link
Copy Markdown

Do they get imported or are they linked to the files when dropped on the application. The reason I ask is because I think it would be awesome to have all my runbooks and README.md files from repositories linked inside of boost notes. It would allow editing them and then not having to copy and paste back into the repos.

@yashha

yashha commented Sep 1, 2017

Copy link
Copy Markdown

Good Idea @TechIsCool, would be interesting to have a way to access linked MD-Files.
At the moment they will get copied.

@kohei-takata kohei-takata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 3ef33c0 into BoostIO:master Sep 23, 2017
@kazup01

kazup01 commented Sep 23, 2017

Copy link
Copy Markdown
Member

Merged

@kazup01 kazup01 mentioned this pull request Sep 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

6 participants