Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Add RealtimeNotification#877

Merged
kohei-takata merged 2 commits into
BoostIO:masterfrom
asmsuechan:add-realtime-info
Sep 22, 2017
Merged

Add RealtimeNotification#877
kohei-takata merged 2 commits into
BoostIO:masterfrom
asmsuechan:add-realtime-info

Conversation

@asmsuechan

@asmsuechan asmsuechan commented Sep 20, 2017

Copy link
Copy Markdown
Contributor

context

We want users to notify tips.

before

after

image

note

I'm not sure how I describe plural notifications, so I managed to show the first notification of them notifications[0]

For tests

  • it should not fail the application even if the notification repository does not exist
  • it should show a notification
@BoostnoteBot

BoostnoteBot commented Sep 20, 2017

Copy link
Copy Markdown
Collaborator

Please make sure to be pasted screenshots of all your changes.
@kazup01

kazup01 commented Sep 20, 2017

Copy link
Copy Markdown
Member

🎉
kohei-takata
kohei-takata approved these changes Sep 22, 2017
View reviewed changes

@kohei-takata kohei-takata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kohei-takata kohei-takata merged commit c762b9a into BoostIO:master Sep 22, 2017
@kazup01 kazup01 mentioned this pull request Sep 23, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@asmsuechan @BoostnoteBot @kazup01 @kohei-takata