Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

iss #832 Make :q work in vim mode#885

Merged
kazup01 merged 3 commits into
BoostIO:masterfrom
asmsuechan:exit-by-comma-q-in-vim-mode
Sep 23, 2017
Merged

iss #832 Make :q work in vim mode#885
kazup01 merged 3 commits into
BoostIO:masterfrom
asmsuechan:exit-by-comma-q-in-vim-mode

Conversation

@asmsuechan

@asmsuechan asmsuechan commented Sep 22, 2017

Copy link
Copy Markdown
Contributor

context

We want to exit from the editor in Vim mode.

before

02a6570e0dd85231d3120aa861a95a83

after

f76f1b74be813ee10f631b1cd41486d0

For test

  • :q exits from editor mode
  • :q! exits from editor mode
  • :qw exits from editor mode
@kazup01

kazup01 commented Sep 22, 2017

Copy link
Copy Markdown
Member

awesome

@KLszTsu

KLszTsu commented Sep 22, 2017

Copy link
Copy Markdown
Contributor

May I ask if :wq (Save and Exit) works either?
I know it don't need to be saved manually but saving is a habit for people like me.

Thanks.

@asmsuechan

asmsuechan commented Sep 22, 2017

Copy link
Copy Markdown
Contributor Author

Sadly it doesn't work because of https://github.com/codemirror/CodeMirror/blob/25e12b5fe1ee7b0be7e7ee4306608caa4e93c6d6/keymap/vim.js#L701.
It means only 1 key is allowed to be defined as my own command.

I misunderstood. I can.

@KLszTsu

KLszTsu commented Sep 22, 2017

Copy link
Copy Markdown
Contributor

Thanks very much anyway.

@KLszTsu

KLszTsu commented Sep 22, 2017

Copy link
Copy Markdown
Contributor

(It should be :wq instead :qw.)

@asmsuechan

Copy link
Copy Markdown
Contributor Author

Exactly 😆

@kazup01 kazup01 merged commit bd266dc into BoostIO:master Sep 23, 2017
@kazup01 kazup01 mentioned this pull request Sep 23, 2017
@asmsuechan asmsuechan deleted the exit-by-comma-q-in-vim-mode branch September 30, 2017 04:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants