Update Build so that Uwp package doesn't include WASDK and vice-versa #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test failure... grr |
Member
Author
|
Packages look good from what I can tell? |
No longer needed
michael-hawker
force-pushed
the
llama/split-package
branch
from
9cc2fd1 to
f37376a
Compare
Member
Author
|
@Arlodotexe rebased on top of tooling pointer to main now that the dependent PR is in, also removed the extraneous prop now too. |
Arlodotexe
approved these changes
Sep 6, 2023
Member
Arlodotexe
left a comment
Arlodotexe
left a comment
There was a problem hiding this comment.
Think it just needs a tooling pointer update then we're gtg
Member
Author
Already done, so we should be clean! :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220
With this change our
Uwpbased packages won't include thenet6/7-windowstargets/WASDKAnd our
WinUIpackages won't include theuaptarget for UWP.This should enable WAPProjects to better handle this scenario (we'll have to test), and mean that Uno folks can't improperly mix-and-match, they'll need to install the package that corresponds to their Uno.UI/Uno.WinUI setup.