Remove recursive type name preservation when parsing meta-data objects #3788
+1,028
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had logic to preserve type names on all nested field types when we parse a file descriptor and turn it into a schema template. However, that can lead to problems if there are multiple nested types with the same name. This adds a yaml test with that configuration, and it also modifies the schema template parsing logic so that we no longer attempt to do this. The type name preservation is still done on top level types, as that is still necessary in order to preserve index type names as well as to generate the FUSE expression off of the correct type names. However, most of the other locations that referenced the type name have been cleaned up so that they work on only the `Type` object.
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. New QueriesCount of new queries by file:
|
Collaborator
Author
|
The test failures are from logic that actually is relying on those types being present. But that's something that we want to remove in #3753. So, I think we should wait for that one to be in and then re-asses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had logic to preserve type names on all nested field types when we parse a file descriptor and turn it into a schema template. However, that can lead to problems if there are multiple nested types with the same name. This adds a yaml test with that configuration, and it also modifies the schema template parsing logic so that we no longer attempt to do this.
The type name preservation is still done on top level types, as that is still necessary in order to preserve index type names as well as to generate the FUSE expression off of the correct type names. However, most of the other locations that referenced the type name have been cleaned up so that they work on only the
Typeobject.This fixes #3789.