Skip to content

feat: Add geom columns for thelook_ecommerce dataset - #307

Merged
nlarge-google merged 3 commits into
mainfrom
shanecglass-patch-1
Aug 25, 2022
Merged

nlarge-google merged 3 commits into
mainfrom
shanecglass-patch-1

Conversation

@shanecglass

Copy link
Copy Markdown
Contributor

Adding a user_geom and distribution_center column of type GEOGRAPHY to user and distribution_center tables

Description

Dataset updated: datasets/thelook_ecommerce/pipelines/thelook_ecommerce/pipeline.yaml

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/<DATASET_NAME> and nothing outside of that directory
Adding a user_geom and distribution_center column of type GEOGRAPHY to user and distribution_center tables
Cleaning up YAML errors to add geom columns for users and distribution_center tables

@shanecglass shanecglass left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on presubmit test failures

Adding a geom column to the users and distribution_center tables

@shanecglass shanecglass left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to remove trailing spaces to clear presubmit errors

@adlersantos adlersantos changed the title feat: add geom columns Mar 14, 2022
@adlersantos
adlersantos self-requested a review March 14, 2022 17:35

@nlarge-google nlarge-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Shane!

@nlarge-google
nlarge-google merged commit f39a177 into main Aug 25, 2022
@nlarge-google
nlarge-google deleted the shanecglass-patch-1 branch August 25, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants