fix: render bash completion block correctly

Author: MNametissa

o2switch_cli/cli/completion_support.py

@@ -43,10 +43,11 @@ def managed_bashrc_block(
     for command_name in command_names:
         command_path = (resolved_completion_dir / command_name).expanduser()
         source_lines.append(f'    [[ -r "{command_path}" ]] && source "{command_path}"')
+    rendered_lines = "\n".join(source_lines)
     return (
         f"{BASHRC_MARKER_START}\n"
         'if [[ -n "${BASH_VERSION:-}" ]]; then\n'
-        f"{source_lines}\n"
+        f"{rendered_lines}\n"
         "fi\n"
         f"{BASHRC_MARKER_END}\n"
     )

tests/test_completion_support.py

@@ -32,10 +32,22 @@ def test_install_and_remove_bash_completion_manage_files_and_bashrc(tmp_path: Pa
     assert "# >>> o2switch-cli completion >>>" in bashrc
     assert str(completion_dir / "o2switch-cli") in bashrc
     assert str(completion_dir / "o2switch_cli") in bashrc
+    assert "['" not in bashrc
+    assert '[[ -r "' in bashrc
+    assert 'source "' in bashrc
 
     removed = remove_bash_completion(completion_dir=completion_dir, bashrc_path=bashrc_path)
 
     assert {path.name for path in removed} == set(COMMAND_NAMES)
     assert not (completion_dir / "o2switch-cli").exists()
     assert not (completion_dir / "o2switch_cli").exists()
     assert "# >>> o2switch-cli completion >>>" not in bashrc_path.read_text()
+
+
+def test_managed_bashrc_block_renders_shell_lines_not_python_list(tmp_path: Path) -> None:
+    completion_dir = tmp_path / "completions"
+    block = install_bash_completion(completion_dir=completion_dir, bashrc_path=tmp_path / ".bashrc")
+    del block
+    rendered = (tmp_path / ".bashrc").read_text()
+    assert "['" not in rendered
+    assert ", '" not in rendered