fix: reuse local install lifecycle

Author: MNametissa

README.md

@@ -21,6 +21,16 @@ Development bootstrap:
 ./install.sh --dev
 ```
 
+Reusing an existing local install:
+
+```bash
+./install.sh
+./install.sh --dev
+./install.sh --reinstall
+```
+
+`install.sh` now reuses the existing `.venv` and skips `pip install -e` when `pyproject.toml` and the selected install profile are unchanged. This matches pip's editable-install behavior: reinstall is mainly needed when project metadata changes.
+
 The installer also publishes launchers into `~/.local/bin` by default:
 
 ```bash
@@ -41,9 +51,12 @@ Standalone uninstall:
 
 ```bash
 ./uninstall.sh
+./uninstall.sh --purge-venv
 ./uninstall.sh --purge-config --purge-state
 ```
 
+`./uninstall.sh` now removes launchers, completion, and managed shell wiring by default, but preserves `.venv` for faster reinstall. Use `--purge-venv` if you want a full local removal.
+
 ## Configuration
 
 Convention de nommage:

install.sh

@@ -3,12 +3,14 @@ set -euo pipefail
 
 ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 VENV_DIR="$ROOT_DIR/.venv"
+INSTALL_STATE_FILE="$VENV_DIR/.o2switch-cli-install-state"
 PYTHON_BIN="${PYTHON_BIN:-python3}"
 PACKAGE_SPEC="."
 RUN_SETUP=1
 TEST_API=0
 ENV_FILE=".env"
 LINK_LOCAL_BIN=1
+FORCE_REINSTALL=0
 LOCAL_BIN_DIR="${HOME}/.local/bin"
 COMPLETION_DIR="${HOME}/.local/share/bash-completion/completions"
 BASHRC_FILE="${HOME}/.bashrc"
@@ -53,6 +55,15 @@ print_shell_refresh_note() {
   echo "    Run: source \"$BASHRC_FILE\" && hash -r"
 }
 
+compute_install_state() {
+  PYTHONPATH="$ROOT_DIR" "$PYTHON_BIN" - <<PY
+from pathlib import Path
+from o2switch_cli.install_support import compute_install_state
+
+print(compute_install_state(Path(r"$ROOT_DIR"), "$PACKAGE_SPEC"))
+PY
+}
+
 usage() {
   cat <<'EOF'
 Usage: ./install.sh [OPTIONS]
@@ -61,6 +72,7 @@ Bootstrap o2switch-cli in a local virtual environment and optionally run the set
 
 Options:
   --dev             Install development dependencies too.
+  --reinstall       Force `pip install -e` even when the existing venv metadata is unchanged.
   --skip-setup      Do not launch `o2switch-cli config init` after install.
   --test-api        Ask the setup command to test API access after writing credentials.
   --env-file PATH   Write credentials to PATH instead of .env.
@@ -75,6 +87,10 @@ while [[ $# -gt 0 ]]; do
       PACKAGE_SPEC=".[dev]"
       shift
       ;;
+    --reinstall)
+      FORCE_REINSTALL=1
+      shift
+      ;;
     --skip-setup)
       RUN_SETUP=0
       shift
@@ -103,15 +119,43 @@ while [[ $# -gt 0 ]]; do
   esac
 done
 
-echo "==> Creating virtual environment in $VENV_DIR"
-"$PYTHON_BIN" -m venv "$VENV_DIR"
+if [[ -x "$VENV_DIR/bin/python" ]]; then
+  echo "==> Reusing virtual environment in $VENV_DIR"
+else
+  echo "==> Creating virtual environment in $VENV_DIR"
+  "$PYTHON_BIN" -m venv "$VENV_DIR"
+fi
 
-echo "==> Installing o2switch-cli"
-"$VENV_DIR/bin/python" -m pip install --upgrade pip
-if [[ "$PACKAGE_SPEC" == ".[dev]" ]]; then
-  "$VENV_DIR/bin/python" -m pip install -e "${ROOT_DIR}[dev]"
+DESIRED_INSTALL_STATE="$(compute_install_state)"
+CURRENT_INSTALL_STATE=""
+if [[ -f "$INSTALL_STATE_FILE" ]]; then
+  CURRENT_INSTALL_STATE="$(<"$INSTALL_STATE_FILE")"
+fi
+
+INSTALL_REASON=""
+if [[ "$FORCE_REINSTALL" -eq 1 ]]; then
+  INSTALL_REASON="forced reinstall"
+elif ! "$VENV_DIR/bin/python" -m pip show o2switch-cli >/dev/null 2>&1; then
+  INSTALL_REASON="package missing from venv"
+elif [[ ! -x "$VENV_DIR/bin/o2switch-cli" ]]; then
+  INSTALL_REASON="launcher missing from venv"
+elif [[ "$CURRENT_INSTALL_STATE" != "$DESIRED_INSTALL_STATE" ]]; then
+  INSTALL_REASON="project metadata changed"
+fi
+
+if [[ -n "$INSTALL_REASON" ]]; then
+  echo "==> Installing o2switch-cli"
+  echo "    Reason: $INSTALL_REASON"
+  "$VENV_DIR/bin/python" -m pip install --upgrade pip
+  if [[ "$PACKAGE_SPEC" == ".[dev]" ]]; then
+    "$VENV_DIR/bin/python" -m pip install -e "${ROOT_DIR}[dev]"
+  else
+    "$VENV_DIR/bin/python" -m pip install -e "$ROOT_DIR"
+  fi
+  printf '%s\n' "$DESIRED_INSTALL_STATE" > "$INSTALL_STATE_FILE"
 else
-  "$VENV_DIR/bin/python" -m pip install -e "$ROOT_DIR"
+  echo "==> Reusing existing editable install"
+  echo "    Metadata unchanged; skipping pip install"
 fi
 
 echo "==> Installed successfully"

o2switch_cli/install_support.py

@@ -0,0 +1,17 @@
+from __future__ import annotations
+
+from hashlib import sha256
+from pathlib import Path
+
+
+def compute_install_state(root_dir: Path, package_spec: str) -> str:
+    resolved_root = root_dir.expanduser().resolve()
+    pyproject_path = resolved_root / "pyproject.toml"
+
+    hasher = sha256()
+    hasher.update(str(resolved_root).encode("utf-8"))
+    hasher.update(b"\0")
+    hasher.update(package_spec.encode("utf-8"))
+    hasher.update(b"\0")
+    hasher.update(pyproject_path.read_bytes())
+    return hasher.hexdigest()

tests/test_install_support.py

@@ -0,0 +1,21 @@
+from __future__ import annotations
+
+from pathlib import Path
+
+from o2switch_cli.install_support import compute_install_state
+
+
+def test_compute_install_state_changes_with_package_spec(tmp_path: Path) -> None:
+    (tmp_path / "pyproject.toml").write_text("[project]\nname = 'demo'\n")
+    base = compute_install_state(tmp_path, ".")
+    dev = compute_install_state(tmp_path, ".[dev]")
+    assert base != dev
+
+
+def test_compute_install_state_changes_with_pyproject_content(tmp_path: Path) -> None:
+    pyproject = tmp_path / "pyproject.toml"
+    pyproject.write_text("[project]\nname = 'demo'\n")
+    before = compute_install_state(tmp_path, ".")
+    pyproject.write_text("[project]\nname = 'demo'\nversion = '0.2.0'\n")
+    after = compute_install_state(tmp_path, ".")
+    assert before != after

uninstall.sh

@@ -8,6 +8,7 @@ COMPLETION_DIR="${HOME}/.local/share/bash-completion/completions"
 ENV_FILE="$ROOT_DIR/.env"
 REMOVE_ENV=0
 REMOVE_STATE=0
+PURGE_VENV=0
 YES=0
 BASHRC_FILE="${HOME}/.bashrc"
 BASHRC_MARKER_START="# >>> o2switch-cli >>>"
@@ -74,6 +75,7 @@ Usage: ./uninstall.sh [OPTIONS]
 Remove the local o2switch-cli installation created by ./install.sh.
 
 Options:
+  --purge-venv     Also remove the repository .venv. By default it is kept for fast reinstall.
   --purge-config   Also remove the repository .env file.
   --purge-state    Also remove the default audit log file and its state directory.
   --yes            Do not ask for confirmation.
@@ -83,6 +85,10 @@ EOF
 
 while [[ $# -gt 0 ]]; do
   case "$1" in
+    --purge-venv)
+      PURGE_VENV=1
+      shift
+      ;;
     --purge-config)
       REMOVE_ENV=1
       shift
@@ -112,11 +118,15 @@ STATE_DIR="$(dirname "$AUDIT_LOG_PATH")"
 
 if [[ "$YES" -ne 1 ]]; then
   echo "This will remove:"
-  echo "  $VENV_DIR"
   echo "  $LOCAL_BIN_DIR/o2switch-cli"
   echo "  $LOCAL_BIN_DIR/o2switch_cli"
   echo "  $COMPLETION_DIR/o2switch-cli"
   echo "  $COMPLETION_DIR/o2switch_cli"
+  if [[ "$PURGE_VENV" -eq 1 ]]; then
+    echo "  $VENV_DIR"
+  else
+    echo "  $VENV_DIR (preserved)"
+  fi
   if [[ "$REMOVE_ENV" -eq 1 ]]; then
     echo "  $ENV_FILE"
   fi
@@ -143,7 +153,9 @@ else
   remove_bashrc_completion_block
 fi
 
-rm -rf "$VENV_DIR"
+if [[ "$PURGE_VENV" -eq 1 ]]; then
+  rm -rf "$VENV_DIR"
+fi
 
 for launcher in "$LOCAL_BIN_DIR/o2switch-cli" "$LOCAL_BIN_DIR/o2switch_cli"; do
   if [[ -e "$launcher" || -L "$launcher" ]]; then
@@ -162,4 +174,7 @@ if [[ "$REMOVE_STATE" -eq 1 ]]; then
 fi
 
 echo "==> Uninstall completed"
+if [[ "$PURGE_VENV" -eq 0 ]]; then
+  echo "    Preserved $VENV_DIR for faster future installs"
+fi
 print_shell_refresh_note