fix(misc): small fixes with smoke VFX

Author: MinaPecheux

Assets/Scripts/Managers/VFXManager.cs

@@ -25,16 +25,15 @@ public void Start()
 
         _vfxPools = new Dictionary<VfxType, Transform>();
 
-        GameObject g;
-        Transform smokePool = Instantiate(poolPrefab).transform;
+        Transform smokePool = Instantiate(poolPrefab, transform).transform;
         smokePool.gameObject.name = "Smoke";
         _vfxPools[VfxType.Smoke] = smokePool;
-        smokePool.SetParent(transform);
         Transform smokeStockParent = smokePool.Find("Stock");
         for (int i = 0; i < SMOKE_EFFECT_POOL_SIZE; i++)
         {
-            g = Instantiate(smokeEffectPrefabs[Random.Range(0, smokeEffectPrefabs.Length)]);
-            g.transform.SetParent(smokeStockParent);
+            Instantiate(
+                smokeEffectPrefabs[Random.Range(0, smokeEffectPrefabs.Length)],
+                smokeStockParent);
         }
     }
 

Assets/Scripts/Units/Buildings/Building.cs

@@ -152,12 +152,16 @@ public void RemoveConstructor(int index)
         _constructors.RemoveAt(index);
         EventManager.TriggerEvent("UpdatedConstructors", this);
 
-        // when removing last constructor, remove smoke VFX
-        foreach (Transform vfx in _smokeVfx)
-            VFXManager.instance.Unspawn(VfxType.Smoke, vfx);
-        _smokeVfx.Clear();
-        // stop construction sound
-        _buildingManager.ambientSource.Pause();
+        // when removing last constructor:
+        if (_constructors.Count == 0)
+        {
+            // - remove smoke VFX
+            foreach (Transform vfx in _smokeVfx)
+                VFXManager.instance.Unspawn(VfxType.Smoke, vfx);
+            _smokeVfx.Clear();
+            // - stop construction sound
+            _buildingManager.ambientSource.Pause();
+        }
     }
 
     private void _SetAlive(bool fromSavedData = false)