fix(game-pause): use Time.timeScale for global pause

Author: MinaPecheux

Assets/Scripts/DayAndNightCycler.cs

@@ -9,8 +9,6 @@ public class DayAndNightCycler : MonoBehaviour
     private float _rotationAngleStep;
     private Vector3 _rotationAxis;
 
-    private Coroutine _starsCoroutine = null;
-
     private void Start()
     {
         // apply initial rotation on stars
@@ -23,35 +21,7 @@ private void Start()
         _starsRefreshRate = 0.1f;
         _rotationAxis = starsTransform.right;
         _rotationAngleStep = 360f * _starsRefreshRate / GameManager.instance.gameGlobalParameters.dayLengthInSeconds;
-        if (!GameManager.instance.gameIsPaused)
-            _starsCoroutine = StartCoroutine("_UpdateStars");
-    }
-
-    private void OnEnable()
-    {
-        EventManager.AddListener("PausedGame", _OnPausedGame);
-        EventManager.AddListener("ResumedGame", _OnResumedGame);
-    }
-
-    private void OnDisable()
-    {
-        EventManager.RemoveListener("PausedGame", _OnPausedGame);
-        EventManager.RemoveListener("ResumedGame", _OnResumedGame);
-    }
-
-    private void _OnPausedGame()
-    {
-        if (_starsCoroutine != null)
-        {
-            StopCoroutine(_starsCoroutine);
-            _starsCoroutine = null;
-        }
-    }
-
-    private void _OnResumedGame()
-    {
-        if (_starsCoroutine == null)
-            _starsCoroutine = StartCoroutine("_UpdateStars");
+        StartCoroutine("_UpdateStars");
     }
 
     private IEnumerator _UpdateStars()

Assets/Scripts/Managers/GameManager.cs

@@ -118,11 +118,13 @@ private void OnDisable()
     private void _OnPausedGame()
     {
         gameIsPaused = true;
+        Time.timeScale = 0;
     }
 
     private void _OnResumedGame()
     {
         gameIsPaused = false;
+        Time.timeScale = 1;
     }
 
     /* game parameters update */

Assets/Scripts/Managers/SoundManager.cs

@@ -54,7 +54,7 @@ private IEnumerator _TransitioningVolume(string volumeParameter, float from, flo
         while (t < delay)
         {
             masterMixer.SetFloat(volumeParameter, Mathf.Lerp(from, to, t / delay));
-            t += Time.deltaTime;
+            t += Time.unscaledDeltaTime;
             yield return null;
         }
         masterMixer.SetFloat(volumeParameter, to);