-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added Tagfile generation and search #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution. So now the end user has a new CMake variable, |
|
Never used it before, but it's obviously a feature by DoxyGen to include library documentation without reparsing the source. |
|
Yes, using this tagfile, a project documentation generated by Doxygen can link to the sfml documentation. I think it could help to easily make user-friendly documentations for those projects, which is always good for new users ! And it is a really small change anyway |
mantognini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a nice little addition at no real cost. Just one little change.
doc/doxyfile.in
Outdated
| # external documentation" for more information about the usage of tag files. | ||
|
|
||
| GENERATE_TAGFILE = | ||
| GENERATE_TAGFILE = @DOXYGEN_OUTPUT_DIR@/html/SFML.tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't put this file in the html sub-directory as it's unrelated to the HTML generated files. One could build the doc using other output format instead. Of course, the other change should be adapted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think the tagfile mechanism is only used to link against HTML documentations, but I might have misunderstood that ? Doxygen's page :
https://www.stack.nl/~dimitri/doxygen/manual/external.html
If that is the case I personnaly think it's natural to have it in the HTML sub-dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example on the site you linked, doesn't add it inside the html directory. As such I wouldn't place it there either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I get it.
It can be installed in the doc directory (parent of html), would this make more sense ? This way it wouldn't be inside the html directory but is still installed in an already standard place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and as I am not used to work with pull requests, reviews and everything : should I commit the changes corresponding to this request or what ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's your PR, so yes, you should provide the change. Additionally, if you could squash your commits, that would be great as well, otherwise I'll just do it when merging. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be installed in the doc directory (parent of html), would this make more sense ?
Yes. :)
|
@LaurentGomila Then the generated documentation will link to this SFML generated documentation (To those given local files) : If a SFML type is mentionned in the other project, it will be a link to this type's SFML documentation page. I just think this could make those projects easier to discover for future new clients ? |
|
Okay now I made changes to generate (and find) the tagfile in the doc folder directly, but I don't understand why there are so many changes indicated on other files ? What did I do wrong ? :s With those settings, it would need to be used this way in external projects : |
|
You merged master into your branch at one point. Would be better to rebase your branch onto the current master instead. 😉 |
|
In this specific case, you want to run something like this: |
|
Done ! Is it okay now ? |
mantognini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
|
Merged in 341bc2a |
Working on Ubuntu 16.04, I don't know if this can directly work on macOS/Windows.