Skip to content

Conversation

@PapyChacal
Copy link
Contributor

Working on Ubuntu 16.04, I don't know if this can directly work on macOS/Windows.

@LaurentGomila
Copy link
Member

Thanks for your contribution.

So now the end user has a new CMake variable, SFML_DOC_DIR, that points to this new file, SFML.tag. And then what? Can you explain what this stuff does?

@MarioLiebisch
Copy link
Member

Never used it before, but it's obviously a feature by DoxyGen to include library documentation without reparsing the source.

@PapyChacal
Copy link
Contributor Author

Yes, using this tagfile, a project documentation generated by Doxygen can link to the sfml documentation. I think it could help to easily make user-friendly documentations for those projects, which is always good for new users ! And it is a really small change anyway

Copy link
Member

@mantognini mantognini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice little addition at no real cost. Just one little change.

(forum thread)

doc/doxyfile.in Outdated
# external documentation" for more information about the usage of tag files.

GENERATE_TAGFILE =
GENERATE_TAGFILE = @DOXYGEN_OUTPUT_DIR@/html/SFML.tag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't put this file in the html sub-directory as it's unrelated to the HTML generated files. One could build the doc using other output format instead. Of course, the other change should be adapted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think the tagfile mechanism is only used to link against HTML documentations, but I might have misunderstood that ? Doxygen's page :
https://www.stack.nl/~dimitri/doxygen/manual/external.html

If that is the case I personnaly think it's natural to have it in the HTML sub-dir.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example on the site you linked, doesn't add it inside the html directory. As such I wouldn't place it there either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I get it.
It can be installed in the doc directory (parent of html), would this make more sense ? This way it wouldn't be inside the html directory but is still installed in an already standard place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and as I am not used to work with pull requests, reviews and everything : should I commit the changes corresponding to this request or what ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's your PR, so yes, you should provide the change. Additionally, if you could squash your commits, that would be great as well, otherwise I'll just do it when merging. 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be installed in the doc directory (parent of html), would this make more sense ?

Yes. :)

@eXpl0it3r eXpl0it3r added this to the 2.5 milestone Jan 2, 2018
@PapyChacal
Copy link
Contributor Author

@LaurentGomila
With this new variable, one can use this mechanism to link his project's documentation against SFML doc, by adding a TAGFILE line to his Doxyfile.in :
TAGFILES = @SFML_DOC_DIR@/SFML.tag=@SFML_DOC_DIR@
(Doxygen need a path to the tagfile, and a path to the corresponding doc)

Then the generated documentation will link to this SFML generated documentation (To those given local files) : If a SFML type is mentionned in the other project, it will be a link to this type's SFML documentation page.

I just think this could make those projects easier to discover for future new clients ?
I don't know if there is an easy way to link to the online SFML documenation, but I think it would be great too, for those projects online documentaions.

@PapyChacal
Copy link
Contributor Author

Okay now I made changes to generate (and find) the tagfile in the doc folder directly, but I don't understand why there are so many changes indicated on other files ? What did I do wrong ? :s

With those settings, it would need to be used this way in external projects :
TAGFILES = @SFML_DOC_DIR@/SFML.tag=@SFML_DOC_DIR@/html

@eXpl0it3r
Copy link
Member

You merged master into your branch at one point. Would be better to rebase your branch onto the current master instead. 😉

@mantognini
Copy link
Member

In this specific case, you want to run something like this:

git rebase upstream/master
git push --force-with-lease
@PapyChacal
Copy link
Contributor Author

Done ! Is it okay now ?

Copy link
Member

@mantognini mantognini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@eXpl0it3r
Copy link
Member

Merged in 341bc2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants