fixed issue with modules and autocommands not getting correct player count due to phantom IDs.

Author: N1Ran

Essentials/AutoCommands.cs

@@ -72,13 +72,14 @@ private bool CanRun(AutoCommand command)
                     }
                 case Trigger.PlayerCount:
 
-                    if (command.Compare == GreaterThan)
-                    {
-                        return MySession.Static?.Players.GetOnlinePlayerCount() > command.TriggerCount;
-                    }
-                    else if (command.Compare == LessThan)
+                    switch (command.Compare)
                     {
-                        return MySession.Static?.Players.GetOnlinePlayerCount() < command.TriggerCount;
+                        case GreaterThan:
+                            return Utilities.GetOnlinePlayerCount() > command.TriggerCount;
+                        case LessThan:
+                            return Utilities.GetOnlinePlayerCount() < command.TriggerCount;
+                        case Equal:
+                            return Math.Abs(Utilities.GetOnlinePlayerCount() - command.TriggerCount) < 1;
                     }
                     break;
 

Essentials/Commands/VotingModule.cs

@@ -261,7 +261,7 @@ private IEnumerable VoteCountdown(TimeSpan time)
                 }
                 else
                 {
-                    double vr = (double)_voteReg.Count / MySession.Static.Players.GetOnlinePlayerCount();
+                    double vr = (double)_voteReg.Count / Utilities.GetOnlinePlayerCount();
                     if (vr >= _command.TriggerRatio)
                     {
                         Context.Torch.CurrentSession.Managers.GetManager<IChatManagerClient>()

Essentials/Utilities.cs

@@ -1,12 +1,9 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using Sandbox.Game.Entities;
 using Sandbox.Game.World;
 using Sandbox.ModAPI;
-using Torch;
 using VRage.Game.ModAPI;
 using VRage.ModAPI;
 using VRage.Utils;
@@ -99,6 +96,23 @@ public static IMyPlayer GetPlayerByNameOrId(string nameOrPlayerId)
             return null;
         }
 
+        public static int GetOnlinePlayerCount()
+        {
+            var result = 0;
+
+            result =  MySession.Static.Players.GetOnlinePlayers()
+                .Count(x => x.IsRealPlayer && !string.IsNullOrEmpty(x.DisplayName));
+
+            return result;
+        }
+
+        public static List<MyPlayer> GetOnlinePlayers()
+        {
+            var result = new List<MyPlayer>(MySession.Static.Players.GetOnlinePlayers()
+                .Where(x => x.IsRealPlayer && !string.IsNullOrEmpty(x.DisplayName)));
+            return result;
+        }
+
         public static string FormatDataSize(double size)
         {
             string p = MyUtils.FormatByteSizePrefix(ref size);