Several Bugfixes in EcoCommands (#212)

* Fix: It possible KeyAlreadyExistException workarounded

It apparently is possible to have 2 Players with Same Steam ID but different Serial ID. Cause unknown.

For both of them the same Identity ID is looked up because that ignores the Serial ID. And therefore I can just replace the value.

Could auso check with if(!containsKey) but since the result will be identical I didn't bother.

* Fix: Credits are Number-Formatted in all eco commands

* Fix: Players can nolonger pay themselves

Players were able to duplicate money by paying themselves.
If Player A has 10,000 credits
And Pays Player A 1,000 credits
He ended up with 11,000 credits.

But there was a warning on server side that the client was out of sync. And if you do anything else, like for example !econ set !econ take or !econ reset it crashed said client.

* Fix: Added missing .DisplayName when Paying player

* Feat: !econ check can now also check offline players

I dont exactly know why that limitation of online only was in place. set, take, give, check should work for offlines too.

Since the others are not important enough (for me at least) I am not doing that with this commit.

* Fix: Responses now inform about the possability that the player is offline

These kind of commands should work with IMyIdentity instead of IMyPlayer especially since the "*" parameter would work for ALL Players (not NPCs)

but since I have no intention to fix it at this point in time. The better message will have to do.

Author: LordTylus

Essentials/Commands/EcoModule.cs

@@ -22,29 +22,30 @@ namespace Essentials.Commands
 {
     [Category("econ")]
     public class EcoModule : CommandModule {
+
         [Command("give", "Add a specified anount of credits into a users account. Use '*' to affect all players")]
         [Permission(MyPromoteLevel.Admin)]
         public void EcoGive(string Player, long amount) {
             if (Player != "*") {
                 var p = Utilities.GetPlayerByNameOrId(Player);
                 if (p == null) {
-                    Context.Respond("Player not found");
+                    Context.Respond("Player is not online or cannot be found!");
                     return;
                 }
                 p.TryGetBalanceInfo(out long balance);
-                Context.Respond($"new bal will be {balance + amount}");
+                Context.Respond($"new bal will be {balance + amount:#,##0}");
                 p.RequestChangeBalance(amount);
-                ModCommunication.SendMessageTo(new NotificationMessage($"{amount} credits have been added to your virtual account", 10000, "Blue"), p.SteamUserId);
+                ModCommunication.SendMessageTo(new NotificationMessage($"{amount:#,##0} credits have been added to your virtual account", 10000, "Blue"), p.SteamUserId);
 
             }
             else {
                 foreach (var p in MySession.Static.Players.GetAllPlayers()) {
                     long IdentityID = MySession.Static.Players.TryGetIdentityId(p.SteamId);
                     MyBankingSystem.ChangeBalance(IdentityID, amount);
-                    ModCommunication.SendMessageTo(new NotificationMessage($"{amount} credits have been added to your virtual account", 10000, "Blue"), p.SteamId);
+                    ModCommunication.SendMessageTo(new NotificationMessage($"{amount:#,##0} credits have been added to your virtual account", 10000, "Blue"), p.SteamId);
                 }
             }
-            Context.Respond($"{amount} credits given to account(s)");
+            Context.Respond($"{amount:#,##0} credits given to account(s)");
         }
 
         [Command("take", "Take a specified anount of credits from a users account. Use '*' to affect all players")]
@@ -53,22 +54,22 @@ public void EcoTake(string Player, long amount) {
             if (Player != "*") {
                 var p = Utilities.GetPlayerByNameOrId(Player);
                 if (p == null) {
-                    Context.Respond("Player not found");
+                    Context.Respond("Player is not online or cannot be found!");
                     return;
                 }
                 long changefactor = 0 - amount;
                 p.RequestChangeBalance(changefactor);
-                ModCommunication.SendMessageTo(new NotificationMessage($"{amount} credits have been taken to your virtual account", 10000, "Blue"), p.SteamUserId);
+                ModCommunication.SendMessageTo(new NotificationMessage($"{amount:#,##0} credits have been taken to your virtual account", 10000, "Blue"), p.SteamUserId);
             }
             else {
                 foreach (var p in MySession.Static.Players.GetAllPlayers()) {
                     long IdentityID = MySession.Static.Players.TryGetIdentityId(p.SteamId);
                     long balance = MyBankingSystem.GetBalance(IdentityID);
                     MyBankingSystem.ChangeBalance(IdentityID, -amount);
-                    ModCommunication.SendMessageTo(new NotificationMessage($"{amount} credits have been taken to your virtual account", 10000, "Blue"), p.SteamId);
+                    ModCommunication.SendMessageTo(new NotificationMessage($"{amount:#,##0} credits have been taken to your virtual account", 10000, "Blue"), p.SteamId);
                 }
             }
-            Context.Respond($"{amount} credits taken from account(s)");
+            Context.Respond($"{amount:#,##0} credits taken from account(s)");
         }
 
         [Command("set", "Set a users account to a specifed balance. Use '*' to affect all players")]
@@ -77,24 +78,24 @@ public void EcoSet(string Player, long amount) {
             if (Player != "*") {
                 var p = Utilities.GetPlayerByNameOrId(Player);
                 if (p == null) {
-                    Context.Respond("Player not found");
+                    Context.Respond("Player is not online or cannot be found!");
                     return;
                 }
                 p.TryGetBalanceInfo(out long balance);
                 long difference = (balance - amount);
                 p.RequestChangeBalance(-difference);
-                ModCommunication.SendMessageTo(new NotificationMessage($"Your balance has been set to {amount} credits!", 10000, "Blue"), p.SteamUserId);
+                ModCommunication.SendMessageTo(new NotificationMessage($"Your balance has been set to {amount:#,##0} credits!", 10000, "Blue"), p.SteamUserId);
             }
             else {
                 foreach (var p in MySession.Static.Players.GetAllPlayers()) {
                     long IdentityID = MySession.Static.Players.TryGetIdentityId(p.SteamId);
                     long balance = MyBankingSystem.GetBalance(IdentityID);
                     long difference = (balance - amount);
                     MyBankingSystem.ChangeBalance(IdentityID, -difference);
-                    ModCommunication.SendMessageTo(new NotificationMessage($"Your balance has been set to {amount} credits!", 10000, "Blue"), p.SteamId);
+                    ModCommunication.SendMessageTo(new NotificationMessage($"Your balance has been set to {amount:#,##0} credits!", 10000, "Blue"), p.SteamId);
                 }
             }
-            Context.Respond($"Balance(s) set to {amount}");
+            Context.Respond($"Balance(s) set to {amount:#,##0}");
         }
 
         [Command("reset", "Reset the credits in a users account to 10,000. Use '*' to affect all players")]
@@ -103,7 +104,7 @@ public void EcoReset(string Player) {
             if (Player != "*") {
                 var p = Utilities.GetPlayerByNameOrId(Player);
                 if (p == null) {
-                    Context.Respond("Player not found");
+                    Context.Respond("Player is not online or cannot be found!");
                     return;
                 }
                 p.TryGetBalanceInfo(out long balance);
@@ -130,14 +131,24 @@ public void EcoTop() {
             ecodata.AppendLine("Summary of balanaces accross the server");
             Dictionary<ulong, long> balances = new Dictionary<ulong, long>();
             foreach (var p in MySession.Static.Players.GetAllPlayers()) {
+
                 long IdentityID = MySession.Static.Players.TryGetIdentityId(p.SteamId);
                 long balance = MyBankingSystem.GetBalance(IdentityID);
-                balances.Add(p.SteamId, balance);
+
+                /*
+                 * Add or Update. We have seen that it is possible to have 
+                 * two players with the same SteamID but different SerialIDs.
+                 * 
+                 * Those also had different identities. But one of which was dead. 
+                 * TryGetIdentityId() Returned the same value in both cases. So no damage done if
+                 * Value is just overwritten.
+                 */
+                balances[p.SteamId] = balance;
             }
             var sorted = balances.OrderByDescending(x => x.Value).ThenBy(x => x.Key);
             foreach (var value in sorted) {
                 var test = MySession.Static.Players.TryGetIdentityNameFromSteamId(value.Key);
-                ecodata.AppendLine($"Player: {MySession.Static.Players.TryGetIdentityNameFromSteamId(value.Key).ToString()} - Balance: {value.Value.ToString()}");
+                ecodata.AppendLine($"Player: {MySession.Static.Players.TryGetIdentityNameFromSteamId(value.Key)} - Balance: {value.Value:#,##0}");
             }
 
             if (Context.Player == null) {
@@ -150,13 +161,13 @@ public void EcoTop() {
         [Command("check", "Check the balance of a specific player")]
         [Permission(MyPromoteLevel.None)]
         public void EcoCheck(string Player) {
-            var p = Utilities.GetPlayerByNameOrId(Player);
+            var p = Utilities.GetIdentityByNameOrIds(Player);
             if (p == null) {
-                Context.Respond("Player is not online or cannot be found!");
+                Context.Respond("Player cannot be found!");
                 return;
             }
-            long balance = MyBankingSystem.GetBalance(p.Identity.IdentityId);
-            Context.Respond($"{p.DisplayName}'s balance is {balance} credits");
+            long balance = MyBankingSystem.GetBalance(p.IdentityId);
+            Context.Respond($"{p.DisplayName}'s balance is {balance:#,##0} credits");
         }
 
         [Command("pay")]
@@ -171,13 +182,21 @@ public void EcoPay(string Player, long amount) {
                 Context.Respond("Player is not online or cannot be found!");
                 return;
             }
-            
-            var finalFromBalance = MyBankingSystem.GetBalance(Context.Player.Identity.IdentityId) - amount;
-            var finalToBalance = MyBankingSystem.GetBalance(p.Identity.IdentityId) + amount;
+
+            var fromIdentitiyId = Context.Player.Identity.IdentityId;
+            var toIdentitiyId = p.Identity.IdentityId;
+
+            if(fromIdentitiyId == toIdentitiyId) {
+                Context.Respond("You cannot pay yourself!");
+                return;
+            }
+
+            var finalFromBalance = MyBankingSystem.GetBalance(fromIdentitiyId) - amount;
+            var finalToBalance = MyBankingSystem.GetBalance(toIdentitiyId) + amount;
 
             MyBankingSystem.RequestTransfer_BroadcastToClients(Context.Player.Identity.IdentityId, p.Identity.IdentityId, amount, finalFromBalance, finalToBalance);
-            ModCommunication.SendMessageTo(new NotificationMessage($"Your have recieved {amount} credits from {Context.Player}!", 10000, "Blue"),p.SteamUserId);
-            ModCommunication.SendMessageTo(new NotificationMessage($"Your have sent {amount} credits to {p.DisplayName}!", 10000, "Blue"),Context.Player.SteamUserId);
+            ModCommunication.SendMessageTo(new NotificationMessage($"Your have recieved {amount:#,##0} credits from {Context.Player.DisplayName}!", 10000, "Blue"),p.SteamUserId);
+            ModCommunication.SendMessageTo(new NotificationMessage($"Your have sent {amount:#,##0} credits to {p.DisplayName}!", 10000, "Blue"),Context.Player.SteamUserId);
         }
 
     }