fix sandbox clean removing faction reputations (#159)

* Some requested commands

* Fix sandbox clean removing faction reputations.

* fixed merger

Co-authored-by: Olatide F <tide1988@live.com>

Author: N1Ran

Essentials/Commands/WorldModule.cs

@@ -6,6 +6,7 @@
 using System.Threading.Tasks;
 using NLog;
 using Sandbox.Engine.Multiplayer;
+using Sandbox.Game;
 using Sandbox.Game.Entities;
 using Sandbox.Game.Entities.Character;
 using Sandbox.Game.Gui;
@@ -27,7 +28,6 @@
 using VRage.Game;
 using VRage.Game.ModAPI;
 using VRage.Network;
-using Sandbox.Game;
 
 namespace Essentials.Commands
 {
@@ -213,7 +213,7 @@ private static bool RemoveFromFaction_Internal(MyIdentity identity)
             var fac = MySession.Static.Factions.GetPlayerFaction(identity.IdentityId);
             if (fac == null)
                 return false;
-
+ 
             /* 
              * VisualScriptLogicProvider takes care of removal of faction if last 
              * identity is kicked, and promotes the next player in line to Founder 
@@ -446,6 +446,12 @@ private static int CleanupReputations()
                 }
             }
 
+            //Add Factions with at least one member to valid identities
+            foreach (var faction in MySession.Static.Factions.Factions.Where(x=>x.Value.Members.Count > 0))
+            {
+                validIdentities.Add(faction.Key);
+            }
+
 
             //might not be necessary, but just in case
             validIdentities.Remove(0);
@@ -459,13 +465,15 @@ private static int CleanupReputations()
                 if (validIdentities.Contains(pair.RelateeId1) && validIdentities.Contains(pair.RelateeId2))
                     continue;
                 collection.Remove(pair);
+                result++;
             }
 
             foreach (var pair in collection1List)
             {
                 if (validIdentities.Contains(pair.RelateeId1) && validIdentities.Contains(pair.RelateeId2))
                     continue;
                 collection2.Remove(pair);
+                result++;
             }