Adjustments to Window Control and changed the ConfigControl tab.

- Moved the code into a private method to keep the main logic clean and fixed where I had the Top and Left switched on load.

- ConfigControl no longer completely shuts down all access.
- Loading it from code behind to pass the TorchServer allows access to the CanRun property.
- Added logic to disable textboxes, listboxes, checkboxes, textboxes, buttons, etc.  Admins can now see their settings without being able to adjust them.

Author: buttheadbob

Torch.Server/Views/ConfigControl.xaml.cs

@@ -5,14 +5,13 @@
 using System.Runtime.CompilerServices;
 using System.Windows;
 using System.Windows.Controls;
+using System.Windows.Controls.Primitives;
 using System.Windows.Data;
-using System.Windows.Media;
 using System.Windows.Threading;
 using Torch.API.Managers;
 using Torch.Server.Annotations;
 using Torch.Server.Managers;
 using Torch.Server.ViewModels;
-using Torch.Views;
 using VRage.Game.ModAPI;
 using VRage.Serialization;
 
@@ -24,23 +23,31 @@ namespace Torch.Server.Views
     public partial class ConfigControl : UserControl, INotifyPropertyChanged
     {
         private InstanceManager _instanceManager;
-
         private bool _configValid;
         public bool ConfigValid { get => _configValid; private set { _configValid = value; OnPropertyChanged(); } }
-
         private List<BindingExpression> _bindingExpressions = new List<BindingExpression>();
+        private TorchServer _server;
 
-        public ConfigControl()
+        public ConfigControl(TorchServer server)
         {
             InitializeComponent();
+            _server = server;
             _instanceManager = TorchBase.Instance.Managers.GetManager<InstanceManager>();
             _instanceManager.InstanceLoaded += _instanceManager_InstanceLoaded;
             DataContext = _instanceManager.DedicatedConfig;
             TorchSettings.DataContext = (TorchConfig)TorchBase.Instance.Config;
             // Gets called once all children are loaded
             Dispatcher.BeginInvoke(DispatcherPriority.Loaded, new Action(ApplyStyles));
+            
+            _server.PropertyChanged += (sender, args) =>
+            {
+                if (args.PropertyName == nameof(TorchServer.CanRun))
+                {
+                    Dispatcher.Invoke(SetReadOnly);
+                }
+            };
         }
-
+        
         private void CheckValid()
         {
             ConfigValid = !_bindingExpressions.Any(x => x.HasError);
@@ -149,5 +156,48 @@ private void RoleEdit_Onlick(object sender, RoutedEventArgs e)
             d.Edit(w.Checkpoint.PromotedUsers.Dictionary);
             _instanceManager.DedicatedConfig.Administrators = w.Checkpoint.PromotedUsers.Dictionary.Where(k => k.Value >= MyPromoteLevel.Admin).Select(k => k.Key.ToString()).ToList();
         }
+        
+        private void SetReadOnly()
+        {
+            foreach (var textbox in GetAllChildren<TextBox>(this))
+            {
+                textbox.IsReadOnly = !_server.CanRun;
+            }
+
+            foreach (var button in GetAllChildren<Button>(this))
+            {
+                button.IsEnabled = _server.CanRun;
+            }
+
+            foreach (var comboBox in GetAllChildren<ComboBox>(this))
+            {
+                comboBox.IsEnabled = _server.CanRun;
+            }
+            
+            foreach (var slider in GetAllChildren<Slider>(this))
+            {
+                slider.IsEnabled = _server.CanRun;
+            }
+            
+            foreach (var checkbox in GetAllChildren<CheckBox>(this))
+            {
+                checkbox.IsEnabled = _server.CanRun;
+            }
+            
+            foreach (var toggleButton in GetAllChildren<ToggleButton>(this))
+            {
+                toggleButton.IsEnabled = _server.CanRun;
+            }
+            
+            foreach (var radioButton in GetAllChildren<RadioButton>(this))
+            {
+                radioButton.IsEnabled = _server.CanRun;
+            }
+            
+            foreach (var listBox in GetAllChildren<ListBox>(this))
+            {
+                listBox.IsEnabled = _server.CanRun;
+            }
+        }
     }
 }

Torch.Server/Views/TorchUI.xaml

@@ -70,21 +70,7 @@
                 <views:LogEventViewer />
             </TabItem>
 
-            <TabItem Header="Configuration">
-                <Grid IsEnabled="{Binding Path=CanRun}">
-                    <Grid.RowDefinitions>
-                        <RowDefinition Height="Auto"/>
-                        <RowDefinition/>
-                    </Grid.RowDefinitions>
-                    <Grid Grid.Row="0">
-                        <Grid.ColumnDefinitions>
-                            <ColumnDefinition Width="Auto"/>
-                            <ColumnDefinition/>
-                        </Grid.ColumnDefinitions>
-                    </Grid>
-                    <views:ConfigControl Grid.Row="1" x:Name="ConfigControl" Margin="3" DockPanel.Dock="Bottom" IsEnabled="{Binding CanRun}"/>
-                </Grid>
-            </TabItem>
+            <TabItem Header="Configuration" Name="ConfigTab" />
             <TabItem Header="Mods">
                 <views:ModListControl/>
             </TabItem>

Torch.Server/Views/TorchUI.xaml.cs

@@ -3,27 +3,21 @@
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
-using System.Threading;
 using System.Threading.Tasks;
-using System.Timers;
 using System.Windows;
 using System.Windows.Controls;
-using System.Windows.Data;
 using System.Windows.Documents;
 using System.Windows.Forms;
 using System.Windows.Input;
 using System.Windows.Media;
-using System.Windows.Media.Imaging;
-using System.Windows.Navigation;
-using System.Windows.Shapes;
 using NLog;
 using NLog.Config;
 using NLog.Targets.Wrappers;
-using Sandbox;
 using Torch.API;
 using Torch.API.Managers;
 using Torch.Patches;
 using Torch.Server.Managers;
+using Torch.Server.Views;
 using MessageBox = System.Windows.MessageBox;
 using MessageBoxResult = System.Windows.MessageBoxResult;
 using Rectangle = System.Drawing.Rectangle;
@@ -48,11 +42,13 @@ public TorchUI(TorchServer server)
         {
             _config = (TorchConfig)server.Config;
             WindowStartupLocation = WindowStartupLocation.Manual;
-
+            SetWindow();
+            
             _server = server;
             // TODO: data binding for whole server
             DataContext = server;
             InitializeComponent();
+            ConfigTab.Content = new ConfigControl(_server);
 
             var config = LogManager.Configuration;
             var customTarget = new NlogCustomTarget()
@@ -95,9 +91,21 @@ private void TorchUI_Loaded(object sender, RoutedEventArgs e)
             _scrollTimer.Tick += ScrollIfNeed;
             _scrollTimer.Interval = 120;
             _scrollTimer.Start();
-            
+
+            _server.GameStateChanged += (game, state) =>
+            {
+                if (state == TorchGameState.Loaded && _config.MinimizeOnServerStart)
+                    BtnStart.Dispatcher.Invoke(() =>  // Cheap way to get to UI thread
+                    {
+                        WindowState = WindowState.Minimized;
+                    });
+            };
+        }
+
+        private void SetWindow()
+        {
             // Set the default window size if no position is saved
-            if ( _config.WindowWidth == 0 || _config.WindowHeight == 0)
+            if ( _config.WindowWidth == 0 && _config.WindowHeight == 0)
             {
                 Width = 980;
                 Height = 588;
@@ -125,8 +133,8 @@ private void TorchUI_Loaded(object sender, RoutedEventArgs e)
             LocationChanged += (_, args) =>
             {
                 if (!_config.SaveWindowChanges) return;
-                _config.WindowX = (int)Top;
-                _config.WindowY = (int)Left;
+                _config.WindowX = (int)Left;
+                _config.WindowY = (int)Top;
                 _config.Save();
             };
             SizeChanged += (_, args) =>
@@ -138,15 +146,6 @@ private void TorchUI_Loaded(object sender, RoutedEventArgs e)
 
             if (_config.StartMinimized)
                 WindowState = WindowState.Minimized;
-
-            _server.GameStateChanged += (game, state) =>
-            {
-                if (state == TorchGameState.Loaded && _config.MinimizeOnServerStart)
-                    BtnStart.Dispatcher.Invoke(() =>  // Cheap way to get to UI thread
-                    {
-                        WindowState = WindowState.Minimized;
-                    });
-            };
         }
 
         private void ScrollIfNeed(object sender, EventArgs e)