Update to internal collection.

- Changed the internal ownership collection from MtObservableSortedDictionary to ObservableDictionary which resolved casting errors.

- Added a try/catch to determine the casting error, will leave it for now but should be safe to remove.

- Added a check if the functional blocks IDModule is not null, which should never be but it's safer.

Author: buttheadbob

Torch.Server/ViewModels/Entities/GridViewModel.cs

@@ -5,6 +5,7 @@
 using Sandbox.Game.Entities;
 using Sandbox.Game.Entities.Cube;
 using Sandbox.Game.World;
+using SharpDX.Toolkit.Collections;
 using Torch.Collections;
 using Torch.Server.ViewModels.Blocks;
 using VRage.Game;
@@ -76,7 +77,7 @@ private void RemoveBlock(MyCubeBlock block)
                 Blocks.Remove(block.BlockDefinition);
 
             long ownerId = block.OwnerId;
-            if (block.OwnerId == 0)
+            if (block.OwnerId == 0 && block.IDModule != null) // IDModule shouldn't be null on a terminal block but it has happened.
                 ownerId = block.IDModule.Owner;
 
             if (ownerId != 0)
@@ -95,26 +96,35 @@ private void RemoveBlock(MyCubeBlock block)
 
         private void AddBlock(MyTerminalBlock block)
         {
-            if (!Blocks.TryGetValue(block.BlockDefinition, out var group))
-                group = Blocks[block.BlockDefinition] = new MtObservableSortedDictionary<long, BlockViewModel>();
-            group.Add(block.EntityId, new BlockViewModel(block, Tree));
+            try
+            {
+                if (!Blocks.TryGetValue(block.BlockDefinition, out var group))
+                    group = Blocks[block.BlockDefinition] = new MtObservableSortedDictionary<long, BlockViewModel>();
+                group.Add(block.EntityId, new BlockViewModel(block, Tree));
 
-            long ownerId = block.OwnerId;
-            if (block.OwnerId == 0)
-                ownerId = block.IDModule.Owner;
+                long ownerId = block.OwnerId;
+                if (block.OwnerId == 0 && block.IDModule != null)
+                    ownerId = block.IDModule.Owner;
 
-            if (ownerId != 0)
-            {
-                var playerIdent = MySession.Static.Players.TryGetIdentity(ownerId);
-                if (playerIdent != null)
+                if (ownerId != 0)
                 {
-                    var name = playerIdent.DisplayName;
-                    if (!Owners.TryGetValue(name, out int count))
-                        Owners[name] = 1;
-                    else
-                        Owners[name] = count + 1; 
+                    var playerIdent = MySession.Static.Players.TryGetIdentity(ownerId);
+                    if (playerIdent != null)
+                    {
+                        var name = playerIdent.DisplayName;
+                        if (!Owners.TryGetValue(name, out int count))
+                            Owners[name] = 1;
+                        else
+                            Owners[name] = count + 1; 
+                    }
                 }
             }
+            catch (Exception)
+            {
+                // Used MtObservableSortedDictionary for Owners collection, which threw errors on some blocks.
+                // Switched to ObservableDictionary and left the try/catch just in case...
+            }
+            
         }
 
         public int BlockCount
@@ -127,7 +137,7 @@ public int BlockCount
             }
         }
 
-        public MtObservableSortedDictionary<string,int> Owners { get; } = new MtObservableSortedDictionary<string, int>();
+        public ObservableDictionary<string,int> Owners { get; } = new ObservableDictionary<string, int>();
 
         private void Grid_OnBlockAdded(MySlimBlock obj)
         {

Torch.Server/Views/Entities/GridView.xaml

@@ -49,10 +49,10 @@
             <TextBox Text="{Binding BlockCount, Mode=OneWay}" Margin="3" />
         </StackPanel>
         <StackPanel Grid.Row="7" Grid.ColumnSpan="2" Orientation="Horizontal">
-            <TextBlock Text="Owners and Blocks" Width="125" ToolTip="Expand the blocklist on the grid entry to populate."/>
+            <TextBlock Text="Owners and Blocks" Width="125" ToolTip="Expand the blocklist on the grid entry to populate." Margin="3"/>
 
             <DataGrid x:Name="DictGrid" AutoGenerateColumns="False" CanUserAddRows="False" 
-                      IsReadOnly="True" ItemsSource="{Binding Owners}" 
+                      IsReadOnly="True" ItemsSource="{Binding Owners, Mode=OneWay}" 
                       Margin="3" ToolTip="Expand the blocklist on the grid entry to populate.">
                 <DataGrid.Columns>
                     <DataGridTextColumn Header="Name" Binding="{Binding Key, Mode=OneWay}"/>