Allow for CORS requests to api.wordpress.org to pass - #1009
Closed
dd32 wants to merge 4 commits into
Closed
Conversation
bgrgicak
self-requested a review
February 7, 2024 09:00
bgrgicak
reviewed
Feb 7, 2024
bgrgicak
left a comment
Collaborator
There was a problem hiding this comment.
@dd32 this PR doesn't work for me, I still get CORS errors when I open the plugins list.
Member
Author
Collaborator
|
Looks like this custom header is causing the issue. If I remove it on trunk, requests work again. |
Collaborator
Collaborator
Member
Author
Kind of; but at the same time, if things are working right now... might be better to just leave it as-is. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is this PR doing?
Fixes CORS requests to WordPress.org, even with custom headers.
What problem is it solving?
See #1003
This is a workaround until https://make.wordpress.org/systems/2024/02/07/cors-requests-for-api-wordpress-org/ is resolved.
How is the problem addressed?
Altering the URI that fetches to api.wordpress.org make, to replace requests to
/path/to/path/index.phpto allow forOPTIONSrequests to reach PHP.Testing Instructions
Untested. Make sure upon booting no networking errors are encountered.