32bit integer workaround - #1014
Merged
Merged
Conversation
This is a temporary workaround to hide the 32bit integer warnings that appear when using various time related function, such as strtotime and mktime.
Collaborator
|
Lovely, thank you @stoph! |
This was referenced Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This is a temporary workaround to hide the 32bit integer warnings that appear when using various time related function, such as strtotime() and mktime().
What problem is it solving?
Hiding the warning messages from being displayed on the page.
How is the problem addressed?
Adding an error handler to ignore warning if it matches the message "fit in a PHP integer"
Testing Instructions
add ?year=123 to any playground URL (e.g. /?year=123). Normally it would display
Warning: mktime(): Epoch doesn't fit in a PHP integer in /wordpress/wp-includes/class-wp-date-query.php on line 3