Blueprints: add unit tests to the mkdir step - #1029
Merged
Merged
Conversation
Collaborator
Periods are valid characters in directory names, see this StackOverflow reply about forbidden characters.
I can't remember off the top of my head, but if it doesn't throw an exception when the directory already exists, then you're right. |
adamziel
reviewed
Feb 22, 2024
adamziel
reviewed
Feb 22, 2024
adamziel
reviewed
Mar 4, 2024
adamziel
reviewed
Mar 4, 2024
Co-authored-by: Adam Zielinski <adam@adamziel.com>
Co-authored-by: Adam Zielinski <adam@adamziel.com>
Collaborator
|
@reimic looks good, let's clean up the PR description and I'm happy to merge. |
Collaborator
|
Thank you @reimic ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds tests to the mkdir step.
Tests directory creation minding idempotence and recursivity.
Part of the #756 effort.