Skip to content

Add arguments to default node spawn method - #1037

Merged
adamziel merged 1 commit into
WordPress:trunkfrom
mho22:add-arguments-to-default-node-spawn-handler-method
Feb 14, 2024
Merged

Add arguments to default node spawn method#1037
adamziel merged 1 commit into
WordPress:trunkfrom
mho22:add-arguments-to-default-node-spawn-handler-method

Conversation

@mho22

@mho22 mho22 commented Feb 13, 2024

Copy link
Copy Markdown
Collaborator

What is this PR doing?

Based on the issue #1032

packages/php-wasm/compile/php/phpwasm-emscripten-library.js on line 198:

if (ENVIRONMENT_IS_NODE) {
    return require('child_process').spawn(command, [], {
	shell: true,
	stdio: ['pipe', 'pipe', 'pipe'],
	timeout: 100,
    });
}

The spawn method should take args into account instead of an empty array.

...
    return require('child_process').spawn(command, args, {
...
@adamziel
adamziel merged commit e7b5a00 into WordPress:trunk Feb 14, 2024
@adamziel

Copy link
Copy Markdown
Collaborator

Thank you so much!

@mho22
mho22 deleted the add-arguments-to-default-node-spawn-handler-method branch February 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants