Fix error on reload site click - #1041
Merged
Merged
Conversation
adamziel
approved these changes
Feb 20, 2024
adamziel
left a comment
adamziel
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR fixes an error when the Delete stored data and start fresh button is clicked.
What problem is it solving?
It allows users to use the Delete stored data and start fresh checkbox.
How is the problem addressed?
This PR adds a default value false to prevent form errors when the default value is undefined.
It also adds a try/catch around
resetVirtualOpfsto ensure Playground doesn't break ifresetVirtualOpfsisn't available.Testing Instructions
npm run devstorage=browserquery string