Fix the login message so it doesn't override another - #1044
Merged
Conversation
Collaborator
|
This is awesome @johnbillion, thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
It fixes an issue in the
0-playground.phpmu-plugin which causes it to overwrite other messages on the wp-login.php screen with its own, rather than appending to them.What problem is it solving?
If a plugin uses the
login_messagefilter to add a message to the wp-login.php screen,0-playground.phpcan overwrite it.How is the problem addressed?
It's addressed by using
add_filter()instead of the incorrectadd_action(), and by appending its message instead of overwriting it.Testing Instructions
?plugin=user-switchingquery variable present/wp-login.phpusing the URL input fieldScreenshots
Before
After