Fix: Playground not starting due to a race condition - #1084
Merged
Conversation
Without this PR, the isConnected() method tries for two seconds before assuming the connection worked out. However, sometimes it takes more than that to reach the remote frame or context. This PR replaces that with an infinite loop that will keep trying until the remote end actually responds. This solves a problem with the progress bar stuck at 0% or 50%. ## Testing instructions Apply the following patch to artificially and synchronously slow down the boot in all contexts (website, remote, worker) ```patch diff --git a/packages/php-wasm/web/src/lib/web-php.ts b/packages/php-wasm/web/src/lib/web-php.ts index 27b976a..e4f9071b5 100644 --- a/packages/php-wasm/web/src/lib/web-php.ts +++ b/packages/php-wasm/web/src/lib/web-php.ts @@ -44,6 +44,10 @@ const fakeWebsocket = () => { }; }; +for (let i = 0; i < 5000000; i++) { + crypto.randomUUID(); +} + export class WebPHP extends BasePHP { /** * Creates a new PHP instance. ``` Then open the local Playground at http://localhost:5400/website-server/ and confirm it starts loading after a few seconds. Repeat a dozen or so times and confirm Playground reliably loads each time. Then do the same without this PR and confirm the progress bar tends to get stuck. I'd love to ship an E2E test with this, but I can't think of a way to build one.
adamziel
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this PR, the isConnected() method tries for two seconds before assuming the connection worked out. However, sometimes it takes more than that to reach the remote frame or context. This PR replaces that with an infinite loop that will keep trying until the remote end actually responds.
This solves a problem with the progress bar stuck at 0% or 50%.
Testing instructions
Apply the following patch to artificially and synchronously slow down the boot in all contexts (website, remote, worker)
Then open the local Playground at http://localhost:5400/website-server/ and confirm it starts loading after a few seconds.
Repeat a dozen or so times and confirm Playground reliably loads each time.
Then do the same without this PR and confirm the progress bar tends to get stuck.
I'd love to ship an E2E test with this, but I can't think of a way to build one.