Comlink API: Pass the context argument to windowEndpoint, not wrap - #1087
Merged
Conversation
Follows up on #1085 that correctly identified the issue with `postMessage` event handlers, but passed the context argument to the wrong function call. `wrap()` uesd in that PR is not responsible for binding the message event handler. `windowEndpoint()` is. This PR fixes the mistake.
adamziel
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #1085 that correctly identified the issue with
postMessageevent handlers, but passed the context argument to the wrong function call.wrap()uesd in that PR is not responsible for binding the message event handler.windowEndpoint()is. This PR fixes the mistake.