Fix shutdown errors - #1104
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1078
What is this PR doing?
If fixes an Asyncify error and memory leak when running PHP shutdown functions.
What problem is it solving?
It adds full support for PHP shutdown functions and prevents crashes.
How is the problem addressed?
By adding Asyncify support for
wasm_sapi_request_shutdownand preventingfreefrom running if memory wasn't allocated.Testing Instructions
npm run dev