Request handler: Remove everything after # from the URL - #1126
Merged
Conversation
Closes #1120 Fixes a bug in the URL parsing where `#foo` is passed to PHP when requesting `/index.php#foo`. ## Testing instructions Confirm the tests passed
adamziel
added
[Type] Bug
brandonpayton
approved these changes
Mar 21, 2024
brandonpayton
left a comment
brandonpayton
left a comment
Member
There was a problem hiding this comment.
The change makes sense, and the tests pass. And the new test fails without the fix to php-request-handler.ts.
Member
|
I went ahead and merged this since it is a simple change. |
dmsnell
reviewed
Mar 22, 2024
dmsnell
left a comment
dmsnell
left a comment
Member
There was a problem hiding this comment.
Very nice change; in hindsight I realize we all should have noticed this.
| request.url.startsWith('https://'); | ||
| const requestedUrl = new URL( | ||
| request.url, | ||
| // Remove the hash part of the URL as it's meant for the server. |
Member
There was a problem hiding this comment.
There's something wrong with this comment. It should either say "it's not meant for the server" or "it's meant only for the client."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1120
Fixes a bug in the URL parsing where
#foois passed to PHP when requesting/index.php#foo.Testing instructions
Confirm the tests passed